Make sure got.mergeOptions(...) can be assigned to defaults
#1008
+44
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szmarczak
commented
Dec 27, 2019
szmarczak
commented
Jan 1, 2020
| @@ -56,7 +56,7 @@ interface GotFunctions { | |||
|
|
|||
| export interface Got extends Record<HTTPAlias, GotFunctions>, GotFunctions { | |||
| stream: GotStream; | |||
| defaults: Defaults | Readonly<Defaults>; | |||
| defaults: Defaults; | |||
There was a problem hiding this comment.
No point in having Defaults | Readonly<Defaults> as in some cases TS misguesses it as Readonly<Defaults> and people have to cast it to Defaults anyway. The JS runtime will throw anyway if anyone tries to modify frozen defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #993