Drop support for Node 14 #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
Aug 4, 2023
package.json
Outdated
| @@ -13,7 +13,7 @@ | |||
| "type": "module", | |||
| "exports": "./index.js", | |||
| "engines": { | |||
| "node": "^14.18.0 || ^16.14.0 || >=18.0.0" | |||
| "node": "^16.14.0 || >=18.0.0 || >=20.0.0" | |||
There was a problem hiding this comment.
I am not sure the exact version range you'd prefer. Please let me know, and I can update it.
ehmicky
commented
Aug 4, 2023
|
|
||
| const escapeArg = arg => { | ||
| if (typeof arg !== 'string' || NO_ESCAPE_REGEXP.test(arg)) { | ||
| return arg; | ||
| } | ||
|
|
||
| return `"${arg.replace(DOUBLE_QUOTES_REGEXP, '\\"')}"`; | ||
| return `"${arg.replaceAll('"', '\\"')}"`; |
There was a problem hiding this comment.
Linting-related updates due to xo upgrade.
ehmicky
commented
Aug 4, 2023
| @@ -44,7 +44,7 @@ | |||
| "dependencies": { | |||
| "cross-spawn": "^7.0.3", | |||
| "get-stream": "^6.0.1", | |||
There was a problem hiding this comment.
Upgrading get-stream is not as straightforward, so I'll do it in a separate PR. This probably should be done before making the major release.
ehmicky
commented
Aug 4, 2023
| @@ -53,16 +53,16 @@ | |||
| "strip-final-newline": "^3.0.0" | |||
There was a problem hiding this comment.
Upgrading signal-exit is not as straightforward because one of the tests relies on internals for that library, so I'll do it in a separate PR.
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops support for Node 14 (breaking change) since it is not maintained anymore.
This also adds CI tests for Node 20.
This also upgrades some dependencies with major releases.