Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(error.js): Add cwd error property #565

Merged
merged 3 commits into from
Jul 26, 2023
Merged

feat(error.js): Add cwd error property #565

merged 3 commits into from
Jul 26, 2023

Conversation

homersimpsons
Copy link
Contributor

@homersimpsons homersimpsons commented Jul 14, 2023

Fixes #564

(I couldn't find any contribution guidelines, so I hope everything is okay)

@ehmicky I let you review this

lib/error.js Outdated Show resolved Hide resolved
lib/error.js Show resolved Hide resolved
@ehmicky
Copy link
Collaborator

ehmicky commented Jul 14, 2023

Thanks for the contribution @homersimpsons!

We should also add:

  • some TypeScript types in index.d.ts
  • some type tests in index.test-d.ts
  • some documentation in the README.md
  • copying that documentation in index.d.ts

Thanks again!

@homersimpsons
Copy link
Contributor Author

Thank you for the feedback, I will certainly do this on Monday 24th

@ehmicky
Copy link
Collaborator

ehmicky commented Jul 14, 2023

Thanks, please take your time!

readme.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks @homersimpsons.
What do you think @sindresorhus?

@sindresorhus sindresorhus merged commit f57fdec into sindresorhus:main Jul 26, 2023
11 checks passed
@homersimpsons homersimpsons deleted the feature/error-cwd branch July 27, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cwd to error
3 participants