Require Node.js 8

Author: sindresorhus

.travis.yml

@@ -5,6 +5,5 @@ language: node_js
 node_js:
   - '10'
   - '8'
-  - '6'
 after_success:
   - './node_modules/.bin/nyc report --reporter=text-lcov | ./node_modules/.bin/coveralls'

index.js

@@ -20,25 +20,31 @@ function handleArgs(command, args, options) {
 	args = parsed.args;
 	options = parsed.options;
 
-	options = Object.assign({
+	options = {
 		maxBuffer: TEN_MEGABYTES,
 		buffer: true,
 		stripFinalNewline: true,
 		preferLocal: true,
 		localDir: options.cwd || process.cwd(),
 		encoding: 'utf8',
 		reject: true,
-		cleanup: true
-	}, options, {
+		cleanup: true,
+		...options,
 		windowsHide: true
-	});
+	};
 
 	if (options.extendEnv !== false) {
-		options.env = Object.assign({}, process.env, options.env);
+		options.env = {
+			...process.env,
+			...options.env
+		};
 	}
 
 	if (options.preferLocal) {
-		options.env = npmRunPath.env(Object.assign({}, options, {cwd: options.localDir}));
+		options.env = npmRunPath.env({
+			...options,
+			cwd: options.localDir
+		});
 	}
 
 	// TODO: Remove in the next major release
@@ -82,7 +88,7 @@ function handleOutput(options, value) {
 }
 
 function handleShell(fn, command, options) {
-	return fn(command, Object.assign({}, options, {shell: true}));
+	return fn(command, {...options, shell: true});
 }
 
 function getStream(process, stream, {encoding, buffer, maxBuffer}) {
@@ -257,14 +263,15 @@ module.exports = (command, args, options) => {
 		}
 	}
 
+	// TODO: Use native "finally" syntax when targeting Node.js 10
 	const handlePromise = () => pFinally(Promise.all([
 		processDone,
 		getStream(spawned, 'stdout', {encoding, buffer, maxBuffer}),
 		getStream(spawned, 'stderr', {encoding, buffer, maxBuffer})
-	]).then(arr => {
-		const result = arr[0];
-		result.stdout = arr[1];
-		result.stderr = arr[2];
+	]).then(results => { // eslint-disable-line promise/prefer-await-to-then
+		const result = results[0];
+		result.stdout = results[1];
+		result.stderr = results[2];
 
 		if (result.error || result.code !== 0 || result.signal !== null) {
 			const error = makeError(result, {
@@ -301,21 +308,29 @@ module.exports = (command, args, options) => {
 
 	handleInput(spawned, parsed.options.input);
 
-	spawned.then = (onfulfilled, onrejected) => handlePromise().then(onfulfilled, onrejected);
-	spawned.catch = onrejected => handlePromise().catch(onrejected);
-	// eslint-disable-next-line no-use-extend-native/no-use-extend-native
+	// eslint-disable-next-line promise/prefer-await-to-then
+	spawned.then = (onFulfilled, onRejected) => handlePromise().then(onFulfilled, onRejected);
+	spawned.catch = onRejected => handlePromise().catch(onRejected);
+
+	// TOOD: Remove the `if`-guard when targeting Node.js 10
 	if (Promise.prototype.finally) {
-		spawned.finally = onfinally => handlePromise().finally(onfinally);
+		spawned.finally = onFinally => handlePromise().finally(onFinally);
 	}
 
 	return spawned;
 };
 
 // TODO: set `stderr: 'ignore'` when that option is implemented
-module.exports.stdout = (...args) => module.exports(...args).then(x => x.stdout);
+module.exports.stdout = async (...args) => {
+	const {stdout} = await module.exports(...args);
+	return stdout;
+};
 
 // TODO: set `stdout: 'ignore'` when that option is implemented
-module.exports.stderr = (...args) => module.exports(...args).then(x => x.stderr);
+module.exports.stderr = async (...args) => {
+	const {stderr} = await module.exports(...args);
+	return stderr;
+};
 
 module.exports.shell = (command, options) => handleShell(module.exports, command, options);
 

lib/errname.js

@@ -9,7 +9,7 @@ if (typeof util.getSystemErrorName === 'function') {
 	module.exports = util.getSystemErrorName;
 } else {
 	try {
-		uv = process.binding('uv');
+		uv = process.binding('uv'); // eslint-disable-line node/no-deprecated-api
 
 		if (typeof uv.errname !== 'function') {
 			throw new TypeError('uv.errname is not a function');

package.json

@@ -10,7 +10,7 @@
 		"url": "sindresorhus.com"
 	},
 	"engines": {
-		"node": ">=6"
+		"node": ">=8"
 	},
 	"scripts": {
 		"test": "xo && nyc ava"
@@ -46,14 +46,14 @@
 		"strip-final-newline": "^2.0.0"
 	},
 	"devDependencies": {
-		"ava": "^1.2.1",
-		"cat-names": "^1.0.2",
-		"coveralls": "^3.0.1",
-		"delay": "^3.0.0",
+		"ava": "^1.3.1",
+		"cat-names": "^2.0.0",
+		"coveralls": "^3.0.3",
+		"delay": "^4.1.0",
 		"is-running": "^2.0.0",
-		"nyc": "^13.0.1",
+		"nyc": "^13.3.0",
 		"tempfile": "^2.0.0",
-		"xo": "^0.23.0"
+		"xo": "^0.24.0"
 	},
 	"nyc": {
 		"exclude": [

test.js

@@ -1,7 +1,7 @@
 import test from 'ava';
 import errname from '../lib/errname';
 
-const isWin = process.platform === 'win32';
+const isWindows = process.platform === 'win32';
 
 // Simulates failure to capture `process.binding('uv');`
 const fallback = code => errname.__test__(null, code);
@@ -22,5 +22,5 @@ function makeTests(name, m, expected) {
 
 const unknown = 'Unknown system error -2';
 
-makeTests('native', errname, isWin ? unknown : 'ENOENT');
+makeTests('native', errname, isWindows ? unknown : 'ENOENT');
 makeTests('fallback', fallback, unknown);