fix(expiring-todo-comments): support monorepos #2159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #403
Maybe related: #1871
The basic change: pass the file-being-linted dirname rather than cwd to
read-pkg-up
. Using cwd meant it would find a monorepo's root package directory. Basically this:For review, worth viewing without whitespace, since a few functions were indented to live inside a helper which knows about the file-being-linted's directory name: https://github.com/sindresorhus/eslint-plugin-unicorn/pull/2159/files?w=1
I haven't added tests because I didn't see any that were actually exercising
read-pkg-up
so far, but maybe I missed something?This could introduce new errors, or make others go away, so I think it qualifies as a breaking change. I think it makes sense for the dependency to depend on the package.json nearest the file being linted though.