prefer-set-has
: Use snapshot to test
#2035
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a refactor to use snapshot test in
prefer-set-has
.I found it's a lot of work to change old test to use snapshot test, so I wrote an internal ESLint rule
internal-rules/fix-snapshot-test
.By changing
will get the job done.
Without
/* fix */
, this rule will disable auto-fix. Since this rule deletes lots of code, I don't want other developer lot their work by accident.