Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision 0.32.20 #810

Merged
merged 2 commits into from Mar 25, 2024
Merged

Revision 0.32.20 #810

merged 2 commits into from Mar 25, 2024

Conversation

sinclairzx81
Copy link
Owner

This PR resolves a TypeScript compiler regression that occurred in between TS 5.3.3 -> 5.4.2. The issue seems isolated to the value/delta/... modules where the inferred TSchema types were emitting with basePath relative src/... paths, and not the relative module path.

// TS 5.3.3 - correct
export type Update = Static<typeof Update>;
export declare const Update: import("../../type/object/object.mjs").TObject<{
    type: import("../../type/literal/literal.mjs").TLiteral<"update">;
    path: import("../../type/string/string.mjs").TString;
    value: import("../../type/unknown/unknown.mjs").TUnknown;
}>;

// TS 5.4.2 - incorrect
export type Update = Static<typeof Update>;
export declare const Update: import("src/type/object/object.mjs").TObject<{
    type: import("src/type/literal/literal.mjs").TLiteral<"update">;
    path: import("src/type/string/string.mjs").TString;
    value: import("src/type/unknown/unknown.mjs").TUnknown;
}>;

This PR resolves the problem by explicitly importing the types using the correct path. Comments have been left to review the compiler behavior in subsequent revisions. It may also be worth introducing post build type assertions on top of the ESM module asserts (for consideration), but would prefer to trust compiler emit.

Fixes #808

@sinclairzx81 sinclairzx81 merged commit 480ba12 into master Mar 25, 2024
18 checks passed
@sinclairzx81 sinclairzx81 deleted the typescript branch March 25, 2024 11:20
@mikicho
Copy link

mikicho commented Mar 25, 2024

Thanks for the quick response!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression bug 0.32.19
2 participants