Revision 0.32.17 #799
Merged
Revision 0.32.17 #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
anytype detection path forStaticDecode.It is noted that even though the
StaticDecodetype is constrained to generic parameters of typeTSchema; passinganyfor a parameter is still permissible asanydoes loosely satisfy this constraint. However in the context of StaticDecode, passinganydoes result in TS2589 instantiation issues due to any yielding union results when used as a left-side operand in conditional expressions (classic example below)This PR attempts to catch
anyfor StaticDecode specifically, principally because StaticDecode makes heavy use of conditional mapping, and where union results foranycause ambiguous resolution during type decoding.