CI: move rack-protection to its own job #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes much more sense because it is common to use rack-protection without sinatra. Ref: sinatra#1971 (comment)
dentarg
force-pushed
the
ci/separate-rack-protection
branch
from
8134284
to
0494959
Compare
I was wrong in this comment. This isn't strictly needed. The problem #1971 tried to solve is actually the problem reported and investigated in #1973. |
|
However, despite this adding some duplication in the workflow code and some more jobs, I like it. I think it makes CI more clear on what passed and didn't pass. Not sure if this will hold up but the workflow ran 15 seconds faster here (4m 30s) vs the latest main run (4m 45s). I'll merge this. |
dentarg
added a commit
to dentarg/sinatra
that referenced
this pull request
Jan 5, 2024
This was the intention with sinatra#1974 but I must have forgot about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes much more sense because it is common to use rack-protection without sinatra.
Ref: #1971 (comment)