Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for Trusted Publishing to RubyGems #1970

Merged
merged 1 commit into from Dec 28, 2023

Conversation

dentarg
Copy link
Member

@dentarg dentarg commented Dec 22, 2023

This makes it possible for anyone who can push a tag to sinatra/sinatra (or access the "Run workflow" button in the Actions UI) to cut a release.

I think that's OK, the overlap between https://rubygems.org/gems/sinatra/owners and https://github.com/orgs/sinatra/teams/team-sinatra is already great. It gives two more people access to cut releases.

Close #1920

- https://blog.rubygems.org/2023/12/14/trusted-publishing.html
- https://guides.rubygems.org/trusted-publishing/

This makes it possible for anyone who can push a tag to sinatra/sinatra
(or access the "Run workflow" button in the Actions UI) to cut a
release.

I think that's OK, the overlap between https://rubygems.org/gems/sinatra/owners and
https://github.com/orgs/sinatra/teams/team-sinatra is great. It gives to
more people access to cut releases.

Close sinatra#1920
@dentarg
Copy link
Member Author

dentarg commented Dec 22, 2023

@dentarg dentarg requested a review from zzak December 22, 2023 19:35
@zzak
Copy link
Member

zzak commented Dec 24, 2023

Makes sense to me, whatever tools you need to make your job easier 🙏

@dentarg dentarg merged commit 5d844ee into sinatra:main Dec 28, 2023
14 checks passed
@dentarg dentarg deleted the trusted-publishing branch December 28, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve release workflow
2 participants