Add base64 to rack-protection runtime dependencies
#1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentarg
requested changes
Sep 11, 2023
There was a problem hiding this comment.
It is rack-protection that should depend on base64, not sinatra: https://github.com/search?q=repo%3Asinatra%2Fsinatra%20base64&type=code
mzishtiaq
force-pushed
the
base64_dependency
branch
2 times, most recently
from
5bb37e3
to
7793032
Compare
|
@dentarg thank you. I have updated the PR and the commit. |
dentarg
reviewed
Sep 12, 2023
This PR adds `base64` to rack-protection.gemspec because `base64` will not be part of the default gems since Ruby 3.4.0.
mzishtiaq
force-pushed
the
base64_dependency
branch
from
7793032
to
f14f8f4
Compare
dentarg
approved these changes
Sep 16, 2023
dentarg
changed the title
base64 to runtime dependenciesbase64 to rack-protection runtime dependencies
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
base64to rack-protection.gemspec becausebase64will not be part of the default gems since Ruby 3.4.0.Resolves #1937