Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Scilab #9995

Merged
merged 3 commits into from
Apr 21, 2024
Merged

Add Scilab #9995

merged 3 commits into from
Apr 21, 2024

Conversation

adamrusted
Copy link
Member

@adamrusted adamrusted commented Dec 1, 2023 •
edited

scilab

Issue: closes #5429

Similarweb rank: 355,025

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Hex taken from this SVG at the same source.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Dec 1, 2023
PeterShaggyNoble
PeterShaggyNoble requested changes Dec 5, 2023
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some pretty significant differences throughout this one, @adamrusted; could you have another looks at it? Examples below with yours in red.

@adamrusted adamrusted added the abandoned Pull requests that have been abandoned by the contributor label Feb 4, 2024
@adamrusted
Copy link
Member Author

@simple-icons/maintainers feel free to pick this one up. I'm not in a place at the moment where I can make appropriate changes.

@adamrusted adamrusted removed the abandoned Pull requests that have been abandoned by the contributor label Feb 8, 2024
@PeterShaggyNoble
Copy link
Member

Still seeing most of those same differences, @adamrusted - will request reviews from others, though, in case the problem is my end.

service-paradis
service-paradis requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing most of those same differences, @adamrusted - will request reviews from others, though, in case the problem is my end.

Same differences spotted here!

service-paradis
service-paradis requested changes Feb 21, 2024
View reviewed changes
icons/scilab.svg Outdated
@@ -0,0 +1 @@
<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Scilab</title><path d="M20.4376 0H3.5624C1.5981 0 0 1.5981 0 3.5624v16.8752C0 22.4019 1.5981 24 3.5624 24h16.8752C22.4019 24 24 22.4019 24 20.4376V3.5624C24 1.5981 22.4019 0 20.4376 0zm2.5406 20.4376c0 1.4009-1.1397 2.5406-2.5406 2.5406H3.5624c-1.4009 0-2.5407-1.1397-2.5407-2.5406V3.5624c0-1.4009 1.1397-2.5407 2.5407-2.5407h16.8752c1.4009 0 2.5406 1.1397 2.5406 2.5407v16.8752zM20.1891 1.8031H3.8109c-1.0967 0-1.989.8923-1.989 1.989v16.4157c0 1.0967.8923 1.989 1.989 1.989h16.3783c1.0967 0 1.989-.8923 1.989-1.989V3.7921c-.0001-1.0967-.8923-1.989-1.9891-1.989zm-.8915 7.6763c.9954 0 1.8024.8172 1.8024 1.8252s-.807 1.8252-1.8024 1.8252-1.8024-.8172-1.8024-1.8252c0-1.0081.807-1.8252 1.8024-1.8252zm-1.8755-1.1206c0 1.008-.807 1.8252-1.8024 1.8252s-1.8024-.8172-1.8024-1.8252.807-1.8252 1.8024-1.8252c.9955 0 1.8024.8171 1.8024 1.8252zm-4.7892-5.3225c.9954 0 1.8024.8172 1.8024 1.8252s-.807 1.8252-1.8024 1.8252-1.8024-.8172-1.8024-1.8252.807-1.8252 1.8024-1.8252zm-8.3523 13.581c-.9954 0-1.8024-.8172-1.8024-1.8252s.807-1.8252 1.8024-1.8252 1.8024.8172 1.8024 1.8252c0 1.0081-.8069 1.8252-1.8024 1.8252zm3.5299 2.699c-.9954 0-1.8024-.8172-1.8024-1.8252s.807-1.8252 1.8024-1.8252 1.8024.8172 1.8024 1.8252-.807 1.8252-1.8024 1.8252zm.4636-8.8733c-.9954 0-1.8024-.8172-1.8024-1.8252s.807-1.8252 1.8024-1.8252 1.8024.8172 1.8024 1.8252-.807 1.8252-1.8024 1.8252zm3.9794 2.6335c-.9954 0-1.8024-.8172-1.8024-1.8252s.807-1.8252 1.8024-1.8252 1.8024.8172 1.8024 1.8252-.807 1.8252-1.8024 1.8252zm3.6413 2.5884c-.9954 0-1.8024-.8172-1.8024-1.8252s.807-1.8252 1.8024-1.8252 1.8024.8172 1.8024 1.8252c.0001 1.008-.8069 1.8252-1.8024 1.8252zm3.9047 1.8814c-.9954 0-1.8024-.8172-1.8024-1.8252s.807-1.8252 1.8024-1.8252 1.8024.8172 1.8024 1.8252-.807 1.8252-1.8024 1.8252z"/></svg>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, the app icon will look better!
I'm seeing small differences in 4 corners (yours in red):
image

Maybe we'll want to ask another maintainers in case the problem is on my side 😅

Mvlprem
Mvlprem reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@Mvlprem Mvlprem left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamrusted There are small differences in all 4 corners

Screenshot from 2024-02-22 19-00-55

@PeterShaggyNoble
Copy link
Member

@service-paradis, how's this look to you before I go any further with it? I redrew all the squares from scratch because, once again, Inkscape was making a mess of the strokes.

m3.8125,1.8027344c-1.1024589,0 -1.9902344,0.8877754 -1.9902344,1.9902344V20.207031c0,1.102459 0.8877755,1.990235 1.9902344,1.990235h16.375c1.102459,0 1.990234,-0.887776 1.990234,-1.990235V3.7929688c0,-1.102459 -0.887775,-1.9902344 -1.990234,-1.9902344zm8.820312,1.234375A1.8024111,1.8252088 0 0 1 14.435547,4.8613281 1.8024111,1.8252088 0 0 1 12.632812,6.6875 1.8024111,1.8252088 0 0 1 10.830078,4.8613281 1.8024111,1.8252088 0 0 1 12.632812,3.0371094Zm2.986329,3.4960937A1.8024111,1.8252088 0 0 1 17.421875,8.359375 1.8024111,1.8252088 0 0 1 15.619141,10.183594 1.8024111,1.8252088 0 0 1 13.816406,8.359375 1.8024111,1.8252088 0 0 1 15.619141,6.5332031ZM8.2734375,6.7929688A1.8024111,1.8252088 0 0 1 10.076172,8.6171875 1.8024111,1.8252088 0 0 1 8.2734375,10.443359 1.8024111,1.8252088 0 0 1 6.4707031,8.6171875 1.8024111,1.8252088 0 0 1 8.2734375,6.7929688Zm3.9804685,2.6328124a1.8024111,1.8252088 0 0 1 1.802735,1.8261718 1.8024111,1.8252088 0 0 1 -1.802735,1.824219 1.8024111,1.8252088 0 0 1 -1.802734,-1.824219 1.8024111,1.8252088 0 0 1 1.802734,-1.8261718zm7.042969,0.052734a1.8024111,1.8252088 0 0 1 1.802734,1.8261724 1.8024111,1.8252088 0 0 1 -1.802734,1.824218 1.8024111,1.8252088 0 0 1 -1.800781,-1.824218 1.8024111,1.8252088 0 0 1 1.800781,-1.8261724zm-3.402344,2.5351564a1.8024111,1.8252088 0 0 1 1.802735,1.826172 1.8024111,1.8252088 0 0 1 -1.802735,1.824218 1.8024111,1.8252088 0 0 1 -1.802734,-1.824218 1.8024111,1.8252088 0 0 1 1.802734,-1.826172zM4.28125,12.966797A1.8024111,1.8252088 0 0 1 6.0839844,14.792969 1.8024111,1.8252088 0 0 1 4.28125,16.617188 1.8024111,1.8252088 0 0 1 2.4785156,14.792969 1.8024111,1.8252088 0 0 1 4.28125,12.966797Zm15.517578,0.929687a1.8024111,1.8252088 0 0 1 1.802734,1.824219 1.8024111,1.8252088 0 0 1 -1.802734,1.826172 1.8024111,1.8252088 0 0 1 -1.802734,-1.826172 1.8024111,1.8252088 0 0 1 1.802734,-1.824219zM7.8105469,15.666016A1.8024111,1.8252088 0 0 1 9.6132812,17.490234 1.8024111,1.8252088 0 0 1 7.8105469,19.316406 1.8024111,1.8252088 0 0 1 6.0078125,17.490234 1.8024111,1.8252088 0 0 1 7.8105469,15.666016ZM3.5644531,0C1.5894451,0 0,1.5894451 0,3.5644531V20.435547C0,22.410555 1.5894451,24 3.5644531,24H20.435547C22.410555,24 24,22.410555 24,20.435547V3.5644531C24,1.5894451 22.410555,0 20.435547,0ZM3.5625,1.0214844h16.875c1.407159,0 2.541016,1.133857 2.541016,2.5410156v16.875c0,1.407159 -1.133857,2.541016 -2.541016,2.541016H3.5625c-1.4071586,0 -2.5410156,-1.133857 -2.5410156,-2.541016V3.5625c0,-1.4071586 1.133857,-2.5410156 2.5410156,-2.5410156z

@service-paradis
Copy link
Member

service-paradis commented Mar 15, 2024 •
edited

@service-paradis, how's this look to you before I go any further with it? I redrew all the squares from scratch because, once again, Inkscape was making a mess of the strokes.

m3.8125,1.8027344c-1.1024589,0 -1.9902344,0.8877754 -1.9902344,1.9902344V20.207031c0,1.102459 0.8877755,1.990235 1.9902344,1.990235h16.375c1.102459,0 1.990234,-0.887776 1.990234,-1.990235V3.7929688c0,-1.102459 -0.887775,-1.9902344 -1.990234,-1.9902344zm8.820312,1.234375A1.8024111,1.8252088 0 0 1 14.435547,4.8613281 1.8024111,1.8252088 0 0 1 12.632812,6.6875 1.8024111,1.8252088 0 0 1 10.830078,4.8613281 1.8024111,1.8252088 0 0 1 12.632812,3.0371094Zm2.986329,3.4960937A1.8024111,1.8252088 0 0 1 17.421875,8.359375 1.8024111,1.8252088 0 0 1 15.619141,10.183594 1.8024111,1.8252088 0 0 1 13.816406,8.359375 1.8024111,1.8252088 0 0 1 15.619141,6.5332031ZM8.2734375,6.7929688A1.8024111,1.8252088 0 0 1 10.076172,8.6171875 1.8024111,1.8252088 0 0 1 8.2734375,10.443359 1.8024111,1.8252088 0 0 1 6.4707031,8.6171875 1.8024111,1.8252088 0 0 1 8.2734375,6.7929688Zm3.9804685,2.6328124a1.8024111,1.8252088 0 0 1 1.802735,1.8261718 1.8024111,1.8252088 0 0 1 -1.802735,1.824219 1.8024111,1.8252088 0 0 1 -1.802734,-1.824219 1.8024111,1.8252088 0 0 1 1.802734,-1.8261718zm7.042969,0.052734a1.8024111,1.8252088 0 0 1 1.802734,1.8261724 1.8024111,1.8252088 0 0 1 -1.802734,1.824218 1.8024111,1.8252088 0 0 1 -1.800781,-1.824218 1.8024111,1.8252088 0 0 1 1.800781,-1.8261724zm-3.402344,2.5351564a1.8024111,1.8252088 0 0 1 1.802735,1.826172 1.8024111,1.8252088 0 0 1 -1.802735,1.824218 1.8024111,1.8252088 0 0 1 -1.802734,-1.824218 1.8024111,1.8252088 0 0 1 1.802734,-1.826172zM4.28125,12.966797A1.8024111,1.8252088 0 0 1 6.0839844,14.792969 1.8024111,1.8252088 0 0 1 4.28125,16.617188 1.8024111,1.8252088 0 0 1 2.4785156,14.792969 1.8024111,1.8252088 0 0 1 4.28125,12.966797Zm15.517578,0.929687a1.8024111,1.8252088 0 0 1 1.802734,1.824219 1.8024111,1.8252088 0 0 1 -1.802734,1.826172 1.8024111,1.8252088 0 0 1 -1.802734,-1.826172 1.8024111,1.8252088 0 0 1 1.802734,-1.824219zM7.8105469,15.666016A1.8024111,1.8252088 0 0 1 9.6132812,17.490234 1.8024111,1.8252088 0 0 1 7.8105469,19.316406 1.8024111,1.8252088 0 0 1 6.0078125,17.490234 1.8024111,1.8252088 0 0 1 7.8105469,15.666016ZM3.5644531,0C1.5894451,0 0,1.5894451 0,3.5644531V20.435547C0,22.410555 1.5894451,24 3.5644531,24H20.435547C22.410555,24 24,22.410555 24,20.435547V3.5644531C24,1.5894451 22.410555,0 20.435547,0ZM3.5625,1.0214844h16.875c1.407159,0 2.541016,1.133857 2.541016,2.5410156v16.875c0,1.407159 -1.133857,2.541016 -2.541016,2.541016H3.5625c-1.4071586,0 -2.5410156,-1.133857 -2.5410156,-2.541016V3.5625c0,-1.4071586 1.133857,-2.5410156 2.5410156,-2.5410156z

I'm still seeing hairline differences at some corners, but could honestly be Inkscape playing games with me too. It is quite minor now, so we could probably go with it!

@service-paradis
Copy link
Member

I'm still seeing the same differences 😅. I'm not sure if I'm still sane Ex.
image

I gave it a try and got the following path:

M3.5605 0C1.5958 0-.002 1.5978-.002 3.5625v16.875C-.002 22.4022 1.5958 24 3.5605 24h16.877C22.4022 24 24 22.4022 24 20.4375V3.5625C24 1.5978 22.4022 0 20.4375 0H3.5605zm0 1.0215h16.877c1.4163 0 2.539 1.1247 2.539 2.541v16.875c0 1.4163-1.1227 2.541-2.539 2.541H3.5605c-1.4163 0-2.539-1.1247-2.539-2.541V3.5625c0-1.4163 1.1227-2.541 2.539-2.541zm.25.7812c-1.0943 0-1.9902.8959-1.9902 1.9903v16.416c0 1.0944.8959 1.9883 1.9902 1.9883h16.377c1.0944 0 1.9902-.894 1.9902-1.9883V3.793c0-1.0944-.8958-1.9903-1.9902-1.9903H3.8105zm8.8223 1.2344a1.8024 1.8252 0 0 1 1.8027 1.8242 1.8024 1.8252 0 0 1-1.8027 1.8262 1.8024 1.8252 0 0 1-1.8027-1.8262 1.8024 1.8252 0 0 1 1.8027-1.8242zm2.9863 3.4961a1.8024 1.8252 0 0 1 1.8028 1.8262 1.8024 1.8252 0 0 1-1.8028 1.8242 1.8024 1.8252 0 0 1-1.8027-1.8242 1.8024 1.8252 0 0 1 1.8027-1.8262zm-7.3457.2598a1.8024 1.8252 0 0 1 1.8028 1.8242 1.8024 1.8252 0 0 1-1.8028 1.8262 1.8024 1.8252 0 0 1-1.8027-1.8262A1.8024 1.8252 0 0 1 8.2734 6.793zm3.9805 2.6328a1.8024 1.8252 0 0 1 1.8027 1.8262 1.8024 1.8252 0 0 1-1.8027 1.8242 1.8024 1.8252 0 0 1-1.8027-1.8242 1.8024 1.8252 0 0 1 1.8027-1.8262zm7.043.0527a1.8024 1.8252 0 0 1 1.8027 1.8262 1.8024 1.8252 0 0 1-1.8027 1.8242 1.8024 1.8252 0 0 1-1.8008-1.8242 1.8024 1.8252 0 0 1 1.8008-1.8262zm-3.4024 2.5352a1.8024 1.8252 0 0 1 1.8028 1.8261 1.8024 1.8252 0 0 1-1.8028 1.8243 1.8024 1.8252 0 0 1-1.8027-1.8243 1.8024 1.8252 0 0 1 1.8027-1.8261zm-11.6133.9531A1.8024 1.8252 0 0 1 6.084 14.793a1.8024 1.8252 0 0 1-1.8027 1.8242 1.8024 1.8252 0 0 1-1.8028-1.8242 1.8024 1.8252 0 0 1 1.8028-1.8262zm15.5176.9297a1.8024 1.8252 0 0 1 1.8028 1.8242 1.8024 1.8252 0 0 1-1.8028 1.8262 1.8024 1.8252 0 0 1-1.8027-1.8262 1.8024 1.8252 0 0 1 1.8027-1.8242zM7.8105 15.666a1.8024 1.8252 0 0 1 1.8028 1.8242 1.8024 1.8252 0 0 1-1.8028 1.8262 1.8024 1.8252 0 0 1-1.8027-1.8262 1.8024 1.8252 0 0 1 1.8027-1.8242z

@PratyushJayachandran
Copy link
Member

@service-paradis and @PeterShaggyNoble I checked the contribution thoroughly. I see no issues anymore.

PratyushJayachandran
PratyushJayachandran approved these changes Apr 21, 2024
View reviewed changes
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @adamrusted 🎉

@PratyushJayachandran PratyushJayachandran merged commit 73e043f into simple-icons:develop Apr 21, 2024
4 checks passed
@simple-icons simple-icons bot mentioned this pull request Apr 21, 2024
Merged
simple-icons bot added a commit that referenced this pull request Apr 21, 2024
@simple-icons
Release 4 new icons and 1 updated icon (v11.13.0)
5971444 
# New Icons

- JSR (#10794) (@LitoMore)
- Pronouns.page (#10829) (@alegiardi)
- Scilab (#9995) (@adamrusted)
- Sunrise (#10815) (@uncenter)

# Updated Icons

- AllTrails (#10798) (@service-paradis)
@adamrusted adamrusted deleted the add/scilab branch April 22, 2024 12:52
davidlj95 pushed a commit to davidlj95/simple-icons that referenced this pull request May 18, 2024
@davidlj95
Add Scilab (simple-icons#9995)
7482b65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mvlprem Mvlprem Mvlprem left review comments

@PratyushJayachandran PratyushJayachandran PratyushJayachandran approved these changes

@PeterShaggyNoble PeterShaggyNoble Awaiting requested review from PeterShaggyNoble

@service-paradis service-paradis Awaiting requested review from service-paradis

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Scilab Icon
5 participants
@adamrusted @PeterShaggyNoble @service-paradis @PratyushJayachandran @Mvlprem