-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Helix icon #11410
Add Helix icon #11410
Conversation
Please add a preview image as directed by the top comment in the PR template. |
Not sure if there it was supposed to be an SVG or something else, but the "Save Preview" and "Copy" buttons on the website fail with |
I'm unable to reproduce this. Would you mind opening an issue on https://github.com/mondeja/simple-icons-website-rs and make sure to include your browser and browser version details? |
I just made the issue, though it might just be a garbage issue now that I look into it. It's definitely something to do with canvas / maybe WASM, but it's something screwy I have set up surely, since it happens on Figma too. |
@kanielrkirby are you still interested in working on this pull request? |
I definitely can, I was under the impression I had addressed your concerns. Is there anything this needs? |
Ah, my apologies! I misread/remembered the earlier conversation incorrectly 😅. I'll ask another reviewer to take a look here (I'm not super familiar with gaps and all that). |
Not a problem! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing! This looks pretty good both in large and small sizes!
# New Icons - CodeCrafters (#11252) (@jrhaberland) - Deutsche Welle (#11479) (@anhthang) - Fresh (#11770) (@LitoMore) - Helix (#11410) (@kanielrkirby) - KDE Plasma (#11671) (@kodalegit) - Nexon (#11763) (@LitoMore) - Vestel (#11747) (@coson-lu)
Issue: closes #8421
Popularity metric:
31.2k GitHub stars
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description