Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helix icon #11410

Merged
merged 6 commits into from
Sep 16, 2024
Merged

Add Helix icon #11410

merged 6 commits into from
Sep 16, 2024

Conversation

kanielrkirby
Copy link
Contributor

@kanielrkirby kanielrkirby commented Jul 5, 2024

image

Issue: closes #8421

Popularity metric:

31.2k GitHub stars

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
anhthang Anh Thang
@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label Jul 5, 2024
@kanielrkirby kanielrkirby mentioned this pull request Jul 5, 2024
@uncenter uncenter changed the title Add Helix icon (#8421) Add Helix icon Jul 5, 2024
@uncenter
Copy link
Member

uncenter commented Jul 5, 2024

Please add a preview image as directed by the top comment in the PR template.

@kanielrkirby
Copy link
Contributor Author

Not sure if there it was supposed to be an SVG or something else, but the "Save Preview" and "Copy" buttons on the website fail with BorrowMut errors, I assume from Rust/WASM @uncenter. I just took a screenshot of it

@uncenter
Copy link
Member

uncenter commented Jul 5, 2024

Not sure if there it was supposed to be an SVG or something else, but the "Save Preview" and "Copy" buttons on the website fail with BorrowMut errors, I assume from Rust/WASM @uncenter. I just took a screenshot of it

I'm unable to reproduce this. Would you mind opening an issue on https://github.com/mondeja/simple-icons-website-rs and make sure to include your browser and browser version details?

kanielrkirby and others added 2 commits July 5, 2024 12:05

Verified

This commit was signed with the committer’s verified signature.
anhthang Anh Thang
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>

Verified

This commit was signed with the committer’s verified signature.
anhthang Anh Thang
- Remove trailing newline.
- Better center the Helix logo in the frame.
@kanielrkirby
Copy link
Contributor Author

Not sure if there it was supposed to be an SVG or something else, but the "Save Preview" and "Copy" buttons on the website fail with BorrowMut errors, I assume from Rust/WASM @uncenter. I just took a screenshot of it

I'm unable to reproduce this. Would you mind opening an issue on https://github.com/mondeja/simple-icons-website-rs and make sure to include your browser and browser version details?

I just made the issue, though it might just be a garbage issue now that I look into it. It's definitely something to do with canvas / maybe WASM, but it's something screwy I have set up surely, since it happens on Figma too.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@uncenter
Copy link
Member

@kanielrkirby are you still interested in working on this pull request?

@kanielrkirby
Copy link
Contributor Author

@kanielrkirby are you still interested in working on this pull request?

I definitely can, I was under the impression I had addressed your concerns. Is there anything this needs?

@uncenter
Copy link
Member

Ah, my apologies! I misread/remembered the earlier conversation incorrectly 😅. I'll ask another reviewer to take a look here (I'm not super familiar with gaps and all that).

@kanielrkirby
Copy link
Contributor Author

Ah, my apologies! I misread/remembered the earlier conversation incorrectly 😅. I'll ask another reviewer to take a look here (I'm not super familiar with gaps and all that).

Not a problem!

Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! This looks pretty good both in large and small sizes!

LitoMore and others added 2 commits September 17, 2024 02:17

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@LitoMore LitoMore merged commit cd1b449 into simple-icons:develop Sep 16, 2024
3 checks passed
@simple-icons simple-icons bot mentioned this pull request Sep 22, 2024
simple-icons bot added a commit that referenced this pull request Sep 22, 2024
# New Icons

- CodeCrafters (#11252) (@jrhaberland)
- Deutsche Welle (#11479) (@anhthang)
- Fresh (#11770) (@LitoMore)
- Helix (#11410) (@kanielrkirby)
- KDE Plasma (#11671) (@kodalegit)
- Nexon (#11763) (@LitoMore)
- Vestel (#11747) (@coson-lu)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Helix
3 participants