Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pronouns.page icon #10829

Merged
merged 9 commits into from
Apr 19, 2024
Merged

Conversation

alegiardi
Copy link
Contributor

pronounsdotpage(1)

Issue: closes #10749

Popularity metric: The Similarweb rank is 49,125. See https://www.similarweb.com/website/pronouns.page/.

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@simple-icons simple-icons bot added the new icon Issues or pull requests for adding a new icon label Apr 18, 2024
@uncenter uncenter changed the title Pronouns.page Icon Add Pronouns.page Icon Apr 18, 2024
@uncenter uncenter changed the title Add Pronouns.page Icon Add Pronouns.page icon Apr 18, 2024
_data/simple-icons.json Outdated Show resolved Hide resolved
@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" xml:space="preserve" width="24cm" height="24cm" viewBox="0 0 240 240"><path d="M149.873 51.535c.574-1.02.089-1.849-1.08-1.849l-20.489.013c-1.169 0-2.614.824-3.205 1.831l-50.203 84.874c-7.005 11.535-16.782 14.084-26.176 12.945-16.128-1.954-24.8-13.786-24.8-29.544 0-15.826 12.885-28.704 28.719-28.704H84.52c1.17 0 2.602-.828 3.18-1.843l11.49-20.054c.582-1.015.098-1.843-1.071-1.843H52.635C23.704 67.36.162 90.885.162 119.805c0 13.973 5.463 29.043 15.397 38.89 9.79 9.705 22.87 13.26 36.83 13.55 7.88.089 29.526-.09 39.672-18.133 11.363-20.21 57.812-102.577 57.812-102.577Zm74.568 29.778c-9.79-9.704-22.87-13.26-36.83-13.549-7.88-.09-29.526.09-39.672 18.133-11.359 20.202-57.812 102.568-57.812 102.568-.574 1.02-.09 1.849 1.08 1.849l20.489-.013c1.169 0 2.614-.824 3.205-1.831l50.203-84.874c7.005-11.535 16.782-14.084 26.176-12.945 16.128 1.954 24.8 13.787 24.8 29.544 0 15.826-12.885 28.704-28.719 28.704H155.48c-1.17 0-2.602.828-3.18 1.843l-11.49 20.054c-.582 1.015-.098 1.844 1.071 1.844h45.484c28.931 0 52.473-23.525 52.473-52.445 0-13.965-5.463-29.034-15.397-38.882z" style="stroke-width:.424969"/></svg>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is massive - currently displying at 24x24cm, and 240x240px. Our guidelines stipulate that icons have to have no width or height attribute, and the viewBox should be 24x24px. Could you have another look at this? If it's playing up, usually has something to do with the DPI of your document and export being different!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi sorry about that, think I uploaded the wrong one - will fix that now! Please ignore the last push :)

@alegiardi
Copy link
Contributor Author

Hi I think I fixed the sizing, not sure why it's still failing the tests! :/ sorry about that!

icons/pronounsdotpage.svg Outdated Show resolved Hide resolved
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
@alegiardi
Copy link
Contributor Author

Thanks @uncenter that worked!! Appreciate the help :)

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @alegiardi, and congrats on the first contribution.
Ta @uncenter for the assist!

@adamrusted adamrusted merged commit 0aacd8f into simple-icons:develop Apr 19, 2024
4 checks passed
@alegiardi
Copy link
Contributor Author

alegiardi commented Apr 19, 2024

Wooo!! Thanks @adamrusted :)

simple-icons bot added a commit that referenced this pull request Apr 21, 2024
# New Icons

- JSR (#10794) (@LitoMore)
- Pronouns.page (#10829) (@alegiardi)
- Scilab (#9995) (@adamrusted)
- Sunrise (#10815) (@uncenter)

# Updated Icons

- AllTrails (#10798) (@service-paradis)
davidlj95 pushed a commit to davidlj95/simple-icons that referenced this pull request May 18, 2024
Co-authored-by: uncenter <47499684+uncenter@users.noreply.github.com>
Co-authored-by: Alessia G <aag228@bath.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Pronouns.page
3 participants