Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TUF: TUF pkg doesn't force update because of singletonTufOnce #686

Open
asraa opened this issue Sep 13, 2022 · 2 comments
Open

TUF: TUF pkg doesn't force update because of singletonTufOnce #686

asraa opened this issue Sep 13, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@asraa
Copy link
Contributor

asraa commented Sep 13, 2022

Description

Even if we force update, for e.g. using Initialize twice in a call when using sigstore as a TUF library (this is VERY rare, but may happen), we still won't execute that because of singletonTufOnce.

Sorry for few details, will be following up asap. Found this when I was testing.

Version
@asraa asraa added the bug Something isn't working label Sep 13, 2022
@znewman01 znewman01 mentioned this issue Feb 8, 2023
Closed
mtrmac pushed a commit to mtrmac/sigstore that referenced this issue Mar 10, 2023
@mattmoor
Create our very own empty package. (sigstore#686)
df0cb5c 
Cosign has it's own flavor of GGCR's `empty` package, which lets users toggle the media type we use with an environment variable.  This creates our own package to mirror this.

This also start to set up an `internal/` package structure that we can use to develop the new package structure without (yet) worrying about breaking folks downstream when we change things.

Related: sigstore/cosign#666
Signed-off-by: Matt Moore <mattomata@gmail.com>
@haydentherapper
Copy link
Contributor

@asraa this was fixed correct?

@asraa
Copy link
Contributor Author

asraa commented May 1, 2023

No I don't think so:

sigstore/pkg/tuf/client.go

Line 269 in c28fdeb

singletonTUFOnce.Do(func() {

Either way, it would be better to close when a test is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asraa @haydentherapper