Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove goroutine usage from SearchLogQuery #1407

Merged
merged 1 commit into from Mar 28, 2023

Conversation

bobcallaway
Copy link
Member

Summary

Release Note

Documentation

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner March 28, 2023 19:13
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1407 (1e1a21d) into main (14e3c4b) will increase coverage by 21.32%.
The diff coverage is 85.29%.

@@             Coverage Diff             @@
##             main    #1407       +/-   ##
===========================================
+ Coverage   43.06%   64.38%   +21.32%     
===========================================
  Files          74       82        +8     
  Lines        7458     7874      +416     
===========================================
+ Hits         3212     5070     +1858     
+ Misses       3910     2157     -1753     
- Partials      336      647      +311     
Flag Coverage Δ
e2etests 47.68% <85.29%> (?)
unittests 43.26% <0.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/entries.go 64.87% <85.29%> (+64.87%) ⬆️

... and 54 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner! Looks good

@bobcallaway bobcallaway merged commit 01a2321 into sigstore:main Mar 28, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.1.0 milestone Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants