Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve validation on intoto v0.0.2 type #1351

Merged
merged 2 commits into from Feb 23, 2023

Conversation

bobcallaway
Copy link
Member

This improves the validation of intoto v0.0.2 types when processed through the SearchLogQuery endpoint.

Signed-off-by: Bob Callaway <bcallaway@google.com>
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1351 (ba3adfb) into main (f75333e) will decrease coverage by 0.03%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main    #1351      +/-   ##
==========================================
- Coverage   64.12%   64.10%   -0.03%     
==========================================
  Files          82       82              
  Lines        7889     7906      +17     
==========================================
+ Hits         5059     5068       +9     
- Misses       2178     2184       +6     
- Partials      652      654       +2     
Flag Coverage Δ
e2etests 47.81% <16.66%> (+0.11%) ⬆️
unittests 42.65% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/types/intoto/v0.0.2/entry.go 66.23% <16.66%> (-3.15%) ⬇️
pkg/types/alpine/v0.0.1/entry.go 72.90% <0.00%> (-1.20%) ⬇️
pkg/types/rekord/v0.0.1/entry.go 66.97% <0.00%> (-0.63%) ⬇️
pkg/api/entries.go 65.94% <0.00%> (+1.95%) ⬆️
pkg/types/entries.go 52.54% <0.00%> (+5.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@haydentherapper
Copy link
Contributor

The new codecov tests may need to be configured or disabled, they’re failing in other projects too.

@haydentherapper
Copy link
Contributor

https://docs.codecov.com/docs/commit-status to configure (this is actually a nice feature)

@bobcallaway bobcallaway merged commit 915f7c5 into sigstore:main Feb 23, 2023
@github-actions github-actions bot added this to the v1.1.0 milestone Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants