Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzzing: open writer later in fuzz utils #1326

Merged
merged 1 commit into from Feb 5, 2023
Merged

Conversation

AdamKorcz
Copy link
Contributor

@AdamKorcz AdamKorcz commented Feb 4, 2023

Signed-off-by: AdamKorcz adam@adalogics.com

Summary

This PR moves the opening of a zip writer later in createArtifactBytes until after createArtifactBytes has checked that there are files to zip. As such, it avoids opening a zip writer if the fuzzer does not create any files to zip.

Release Note

Documentation

Signed-off-by: AdamKorcz <adam@adalogics.com>
@AdamKorcz AdamKorcz requested a review from a team as a code owner February 4, 2023 17:41
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

Merging #1326 (a3b2dfd) into main (a90366e) will decrease coverage by 0.04%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
- Coverage   63.40%   63.36%   -0.04%     
==========================================
  Files          82       82              
  Lines        7869     7869              
==========================================
- Hits         4989     4986       -3     
- Misses       2253     2255       +2     
- Partials      627      628       +1     
Flag Coverage Δ
e2etests 46.88% <ø> (+0.02%) ⬆️
unittests 42.89% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/types/alpine/v0.0.1/entry.go 72.90% <0.00%> (-1.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bobcallaway bobcallaway merged commit de84370 into sigstore:main Feb 5, 2023
@github-actions github-actions bot added this to the v1.1.0 milestone Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants