Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused tool/deps #1244

Merged

Conversation

naveensrinivasan
Copy link
Contributor

  • Removed unused tool deps.

Signed-off-by: naveensrinivasan 172697+naveensrinivasan@users.noreply.github.com

- Removed unused tool deps.

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan naveensrinivasan requested a review from a team as a code owner December 14, 2022 21:23
@codecov-commenter
Copy link

Codecov Report

Merging #1244 (3d9c09f) into main (bf488af) will decrease coverage by 21.18%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1244       +/-   ##
===========================================
- Coverage   63.23%   42.04%   -21.19%     
===========================================
  Files          82       74        -8     
  Lines        7670     7225      -445     
===========================================
- Hits         4850     3038     -1812     
- Misses       2208     3878     +1670     
+ Partials      612      309      -303     
Flag Coverage Δ
e2etests ?
unittests 42.04% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/metrics.go 0.00% <0.00%> (-100.00%) ⬇️
cmd/rekor-cli/app/useragent.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/api/trillian_client.go 0.00% <0.00%> (-66.31%) ⬇️
pkg/api/api.go 0.00% <0.00%> (-64.29%) ⬇️
pkg/api/entries.go 0.00% <0.00%> (-64.00%) ⬇️
pkg/types/types.go 0.00% <0.00%> (-63.64%) ⬇️
pkg/types/versionmap.go 0.00% <0.00%> (-63.42%) ⬇️
pkg/api/error.go 0.00% <0.00%> (-58.70%) ⬇️
cmd/rekor-cli/app/verify.go 2.47% <0.00%> (-53.72%) ⬇️
cmd/rekor-cli/app/log_info.go 2.50% <0.00%> (-52.50%) ⬇️
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cpanato cpanato merged commit b706fea into sigstore:main Dec 15, 2022
@github-actions github-actions bot added this to the v1.1.0 milestone Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants