Fuzzing: add more fuzzers #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1215 +/- ##
==========================================
- Coverage 64.22% 64.19% -0.03%
==========================================
Files 82 82
Lines 7628 7628
==========================================
- Hits 4899 4897 -2
- Misses 2100 2102 +2
Partials 629 629
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bobcallaway
reviewed
Nov 28, 2022
bobcallaway
reviewed
Nov 30, 2022
Signed-off-by: AdamKorcz <adam@adalogics.com>
bobcallaway
approved these changes
Nov 30, 2022
| } | ||
| defer func() { | ||
| keyPath.Close() | ||
| os.Remove(keyPath.Name()) |
There was a problem hiding this comment.
You don't need to call os.Remove as the directory (and it's contents) created by t.TempDir() is removed automatically when the test is finished.
|
|
||
| func FuzzNewFile(f *testing.F) { | ||
| f.Fuzz(func(t *testing.T, keyData []byte, keyPass string) { | ||
| keyPath, err := os.CreateTemp(t.TempDir(), "keyfile") |
There was a problem hiding this comment.
Maybe rename keyPath to keyFile as CreateTemp returns a *File, not a path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AdamKorcz adam@adalogics.com
Summary
Adds three more fuzzers.
Release Note
Documentation