Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests - Additional sharding tests #1180

Merged

Conversation

naveensrinivasan
Copy link
Contributor

Tests - Additional sharding tests
Signed-off-by: naveensrinivasan 172697+naveensrinivasan@users.noreply.github.com

@naveensrinivasan naveensrinivasan requested a review from a team as a code owner November 6, 2022 17:00
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Merging #1180 (9bbfda9) into main (3f39194) will increase coverage by 0.25%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1180      +/-   ##
==========================================
+ Coverage   63.25%   63.51%   +0.25%     
==========================================
  Files          82       82              
  Lines        7863     7863              
==========================================
+ Hits         4974     4994      +20     
+ Misses       2258     2242      -16     
+ Partials      631      627       -4     
Flag Coverage Δ
e2etests 46.76% <ø> (+0.02%) ⬆️
unittests 43.25% <ø> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/types/rekord/v0.0.1/entry.go 66.97% <0.00%> (-0.63%) ⬇️
pkg/types/alpine/v0.0.1/entry.go 72.90% <0.00%> (ø)
pkg/sharding/ranges.go 83.19% <0.00%> (+18.48%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pkg/sharding/ranges_test.go Show resolved Hide resolved
pkg/sharding/ranges_test.go Outdated Show resolved Hide resolved
ctx context.Context
r LogRange
}
tests := []struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about testing a case where wantErr == false?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what I could pass to this func not to return an error.

if err := root.UnmarshalBinary(resp.SignedLogRoot.LogRoot); err != nil {
			return LogRange{}, err
		}

I am mocking the call.

pkg/sharding/ranges_test.go Outdated Show resolved Hide resolved
pkg/sharding/ranges_test.go Outdated Show resolved Hide resolved
@naveensrinivasan
Copy link
Contributor Author

@bobcallaway Friendly reminder

@bobcallaway
Copy link
Member

@bobcallaway Friendly reminder

The tests aren't passing, can you take a look? thanks!

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan
Copy link
Contributor Author

@bobcallaway Friendly reminder

The tests aren't passing, can you take a look? thanks!

Took care of it!

bobcallaway
bobcallaway previously approved these changes Dec 13, 2022
Signed-off-by: Bob Callaway <bobcallaway@users.noreply.github.com>
bobcallaway
bobcallaway previously approved these changes Jan 3, 2023
Signed-off-by: Bob Callaway <bobcallaway@users.noreply.github.com>
@bobcallaway bobcallaway merged commit 50361ac into sigstore:main Mar 6, 2023
@github-actions github-actions bot added this to the v1.1.0 milestone Mar 6, 2023
@naveensrinivasan naveensrinivasan deleted the naveen/feat/shardingtests branch March 6, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants