Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamping rekor e2e - part 3 of N #1177

Merged

Conversation

naveensrinivasan
Copy link
Contributor

Summary

Moving the test files to respective folders.
#1075

Release Note

NONE

Documentation

NONE

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan naveensrinivasan force-pushed the naveen/feat/refactor-e2e-files branch 5 times, most recently from 0e2a499 to 3d4a4d0 Compare November 5, 2022 01:57
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2022

Codecov Report

Merging #1177 (7f5bbbd) into main (05d92d3) will decrease coverage by 22.25%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1177       +/-   ##
===========================================
- Coverage   64.20%   41.94%   -22.26%     
===========================================
  Files          82       74        -8     
  Lines        7621     7204      -417     
===========================================
- Hits         4893     3022     -1871     
- Misses       2100     3873     +1773     
+ Partials      628      309      -319     
Flag Coverage Δ
e2etests ?
unittests 41.94% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/metrics.go 0.00% <0.00%> (-100.00%) ⬇️
cmd/rekor-cli/app/useragent.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/api/trillian_client.go 0.00% <0.00%> (-66.31%) ⬇️
pkg/api/api.go 0.00% <0.00%> (-64.29%) ⬇️
pkg/api/entries.go 0.00% <0.00%> (-64.00%) ⬇️
pkg/types/types.go 0.00% <0.00%> (-63.64%) ⬇️
pkg/types/versionmap.go 0.00% <0.00%> (-63.42%) ⬇️
pkg/api/error.go 0.00% <0.00%> (-59.78%) ⬇️
cmd/rekor-cli/app/verify.go 2.47% <0.00%> (-53.72%) ⬇️
cmd/rekor-cli/app/log_info.go 2.50% <0.00%> (-52.50%) ⬇️
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan
Copy link
Contributor Author

@bobcallaway Friendly reminder

Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should cmd/rekor-cli/app/helm.json exist? otherwise lgtm

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
@naveensrinivasan
Copy link
Contributor Author

should cmd/rekor-cli/app/helm.json exist? otherwise lgtm

It shouldn't. I have removed it.

@bobcallaway bobcallaway merged commit b0ef65a into sigstore:main Nov 30, 2022
@github-actions github-actions bot added this to the v1.1.0 milestone Nov 30, 2022
@naveensrinivasan naveensrinivasan deleted the naveen/feat/refactor-e2e-files branch November 30, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants