Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrap redis client errors to aid debugging #1176

Merged
merged 1 commit into from Nov 18, 2022

Conversation

bobcallaway
Copy link
Member

Fixes: #1169

Signed-off-by: Bob Callaway bcallaway@google.com

Signed-off-by: Bob Callaway <bcallaway@google.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1176 (9244079) into main (7412e93) will decrease coverage by 22.26%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #1176       +/-   ##
===========================================
- Coverage   64.23%   41.97%   -22.27%     
===========================================
  Files          82       74        -8     
  Lines        7623     7207      -416     
===========================================
- Hits         4897     3025     -1872     
- Misses       2098     3874     +1776     
+ Partials      628      308      -320     
Flag Coverage Δ
e2etests ?
unittests 41.97% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/api/index.go 40.35% <0.00%> (-30.83%) ⬇️
pkg/api/metrics.go 0.00% <0.00%> (-100.00%) ⬇️
cmd/rekor-cli/app/useragent.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/api/trillian_client.go 0.00% <0.00%> (-66.31%) ⬇️
pkg/api/api.go 0.00% <0.00%> (-64.29%) ⬇️
pkg/api/entries.go 0.00% <0.00%> (-64.00%) ⬇️
pkg/types/types.go 0.00% <0.00%> (-63.64%) ⬇️
pkg/types/versionmap.go 0.00% <0.00%> (-63.42%) ⬇️
pkg/api/error.go 0.00% <0.00%> (-59.78%) ⬇️
cmd/rekor-cli/app/verify.go 2.47% <0.00%> (-53.72%) ⬇️
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukehinds lukehinds merged commit fc13b61 into sigstore:main Nov 18, 2022
@github-actions github-actions bot added this to the v1.1.0 milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rekor should indicate in its logs which external system is causing an error
5 participants