Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parseExtension function to be public #1584

Merged
merged 1 commit into from Feb 28, 2024

Conversation

jkjell
Copy link
Contributor

@jkjell jkjell commented Feb 28, 2024

Summary

Close #1583. The extensions_test.go has also been updated.

Release Note

Changed the pkg/certificate/parseExtensions to be public allowing external Fulcio certificate consumers to parse all x509 extensions into the Extensions struct.

Documentation

None

Signed-off-by: John Kjell <john@testifysec.com>
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.02%. Comparing base (cf238ac) to head (352b777).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1584      +/-   ##
==========================================
+ Coverage   57.93%   60.02%   +2.08%     
==========================================
  Files          50       50              
  Lines        3119     2449     -670     
==========================================
- Hits         1807     1470     -337     
+ Misses       1154      819     -335     
- Partials      158      160       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haydentherapper haydentherapper merged commit c0c61bb into sigstore:main Feb 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make pkg/certificate/parseExtentions function public
2 participants