Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug docker-compose setup #1529

Merged
merged 1 commit into from Jan 19, 2024
Merged

Conversation

cmurphy
Copy link
Contributor

@cmurphy cmurphy commented Jan 18, 2024

  • Update dlv version to be compatible with Go 1.21
  • Add required flag --ca to fulcio command
  • Switch from "command" to "entrypoint" to override the ENTRYPOINT in the Dockerfile
  • Use ports consistent with the main docker-compose file to avoid conflicting with rekor
  • Use metrics port environment variable which was missed in ca33c98

Summary

Release Note

NONE

Documentation

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0be7397) 57.67% compared to head (751ea4a) 57.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1529      +/-   ##
==========================================
- Coverage   57.67%   57.58%   -0.10%     
==========================================
  Files          50       50              
  Lines        3112     3112              
==========================================
- Hits         1795     1792       -3     
- Misses       1158     1160       +2     
- Partials      159      160       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Update dlv version to be compatible with Go 1.21
- Add required flag --ca to fulcio command
- Switch from "command" to "entrypoint" to override the ENTRYPOINT in
  the Dockerfile
- Use ports consistent with the main docker-compose file to avoid
  conflicting with rekor
- Use metrics port environment variable which was missed in ca33c98

Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
@haydentherapper haydentherapper merged commit f2a8d1a into sigstore:main Jan 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants