Add support for OpenVEX predicate type #3405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3405 +/- ##
==========================================
+ Coverage 29.70% 30.21% +0.51%
==========================================
Files 155 155
Lines 9966 9966
==========================================
+ Hits 2960 3011 +51
+ Misses 6575 6505 -70
- Partials 431 450 +19 ☔ View full report in Codecov by Sentry. |
hectorj2f
reviewed
Dec 3, 2023
hectorj2f
reviewed
Dec 3, 2023
OpenVEX is an implementation of the Vulnerability Exploitability Exchange (VEX) designed to be attestable, SBOM-agnostic and lightweight. It is hosted in the OpenSSF Vulnerability Disclosures WG and has support in popular scanners such as Trivy adn Grype. This PR adds support for openvex predicates to the `cosign attest` and `cosign download attestation` commands. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
|
I also added a link to our current attestation spec: https://github.com/openvex/spec/blob/main/ATTESTING.md |
hectorj2f
approved these changes
Dec 6, 2023
haydentherapper
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for OpenVEX as a known predicate type to the
cosign attestandcosign download attestationandcosign attest-blobcommands.Instead of linking the openvex go-modules, I've hardcoded the value or the predicate URI in a const to avoid growing the dependency tree.
Resolves #3404
Release Note
openvexas the type.Documentation
TBD
Signed-off-by: Adolfo García Veytia (Puerco) puerco@chainguard.dev