Add --yes flag cosign import-key-pair to skip the overwrite confirmation.
#3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhaoyonghe <yonghe.zhao@yahoo.com>
zhaoyonghe
commented
Nov 21, 2023
| @@ -39,4 +41,7 @@ func (o *ImportKeyPairOptions) AddFlags(cmd *cobra.Command) { | |||
| cmd.Flags().StringVarP(&o.OutputKeyPrefix, "output-key-prefix", "o", "import-cosign", | |||
| "name used for outputted key pairs") | |||
| _ = cmd.Flags().SetAnnotation("output-key-prefix", cobra.BashCompFilenameExt, []string{}) | |||
|
|
|||
| cmd.Flags().BoolVarP(&o.SkipConfirmation, "yes", "y", false, | |||
| "skip confirmation prompts for non-destructive operations") | |||
There was a problem hiding this comment.
Question: is file overwrite considered as destructive operation? Should we change it to a different name?
There was a problem hiding this comment.
Yes, this should say destructive. Given the simplicity of this command, you could just say "skip confirmation prompts for overwriting existing key"
Signed-off-by: zhaoyonghe <yonghe.zhao@yahoo.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3383 +/- ##
==========================================
- Coverage 30.23% 30.22% -0.02%
==========================================
Files 155 155
Lines 9958 9962 +4
==========================================
Hits 3011 3011
- Misses 6497 6501 +4
Partials 450 450 ☔ View full report in Codecov by Sentry. |
haydentherapper
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #3382.
Summary
Users may call
cosign import-key-pairand thencosign signmultiple times to sign multiple images in CI/CD pipelines. And cannot confirm overwrite:It is better to add a
--yesflag to skip the overwrite confirmation.Release Note
Added
--yesflag incosign import-key-pairto skip the overwrite confirmation.Documentation
Already updated doc/cosign_import-key-pair.md.