Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump builder image to use go1.21.4 and add new cosign image tags with shell #3373

Merged
merged 3 commits into from Nov 19, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 19, 2023

Summary

  • bump builder image to use go1.21.4
  • build -dev tag images that have a shell

also building the image only if the binaries and GitHub release is successfully released

Now, when we release, we will generate the following images:

  • gcr.io/projectsigstore/cosign:vx.y.z no shell
  • gcr.io/projectsigstore/cosign:vx.y.z-dev with shell

Fixes: #3361

Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d5da268) 30.23% compared to head (0585df2) 30.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3373   +/-   ##
=======================================
  Coverage   30.23%   30.23%           
=======================================
  Files         155      155           
  Lines        9958     9958           
=======================================
  Hits         3011     3011           
  Misses       6497     6497           
  Partials      450      450           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…the current workflows

Signed-off-by: cpanato <ctadeu@gmail.com>
@hectorj2f hectorj2f merged commit f1aaa95 into sigstore:main Nov 19, 2023
28 checks passed
@github-actions github-actions bot added this to the v2.3.0 milestone Nov 19, 2023
@cpanato cpanato deleted the updates branch November 19, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosign 2.2.1 Docker image missing /bin/sh
2 participants