Fix idempotency error with signing #3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expected behavior is to fetch an existing entry from the log when signing generates the same signature, so that signing is idempotent. The bug was that the prepended shard ID was compared to the log ID. The log ID is a sha256 hash of the log's public key, which is not the same as the shard ID. Now we compare the prepended shard IDs from both the request and response entry UUID when present. This was not caught in tests since we used a valid shard ID as input rather than the log ID. Verified by generating an RSA key (which will generate the same signature given the same input) and signing a container. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3371 +/- ##
==========================================
- Coverage 30.26% 30.23% -0.04%
==========================================
Files 155 155
Lines 9941 9958 +17
==========================================
+ Hits 3009 3011 +2
- Misses 6482 6497 +15
Partials 450 450 ☔ View full report in Codecov by Sentry. |
bobcallaway
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expected behavior is to fetch an existing entry from the log when signing generates the same signature and that entry is uploaded to the log, so that signing is idempotent.
The bug was that the prepended shard ID was compared to the log ID. The log ID is a sha256 hash of the log's public key, which is not the same as the shard ID. Now we compare the prepended shard IDs from both the request and response entry UUID when present.
This was not caught in tests since we used a valid shard ID as input rather than the log ID.
Verified by generating an RSA key (which will generate the same signature given the same input) and signing a container.
Fixes #3356
Summary
Release Note
Documentation