docs: improves the Contribution guidelines #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgalante
force-pushed
the
main
branch
2 times, most recently
from
db468f1
to
e9fbdc6
Compare
haydentherapper
requested changes
Sep 22, 2023
|
Thanks for the suggestions! |
andresgalante
force-pushed
the
main
branch
3 times, most recently
from
47c9a34
to
d1f17cd
Compare
haydentherapper
requested changes
Sep 25, 2023
Signed-off-by: Andres <andres@Andres-Galante-DQV0F2QFT6.local>
|
Thanks for the review and suggestions @hectorj2f Changes are made, and I squashed my commit |
Codecov Report
@@ Coverage Diff @@
## main #3257 +/- ##
==========================================
+ Coverage 29.83% 30.35% +0.51%
==========================================
Files 155 155
Lines 9845 9845
==========================================
+ Hits 2937 2988 +51
+ Misses 6480 6410 -70
- Partials 428 447 +19 |
lance
pushed a commit
to securesign/cosign
that referenced
this pull request
Sep 25, 2023
Signed-off-by: Andres <andres@Andres-Galante-DQV0F2QFT6.local> Co-authored-by: Andres <andres@Andres-Galante-DQV0F2QFT6.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was running the contribution guidelines I noticed that there were some assumptions, for example, the fact that it expects that the contributor already has Go installed.
This contribution aims to improve the contribution guidelines to allow more people to run the project 馃榿
Let me know what you think