attest: pass OCI remote opts to att resolver. #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need cred helpers and other info set in the remote opts to resolve the upstream attesations, otherwise this will fail in automated environments. Signed-off-by: Billy Lynch <billy@chainguard.dev>
wlynch
force-pushed
the
attest-remoteopts
branch
from
3717997
to
422c6f7
Compare
Codecov Report
@@ Coverage Diff @@
## main #3225 +/- ##
=======================================
Coverage 30.33% 30.33%
=======================================
Files 155 155
Lines 9827 9827
=======================================
Hits 2981 2981
Misses 6398 6398
Partials 448 448
|
cpanato
approved these changes
Sep 7, 2023
|
thanks! |
lance
pushed a commit
to securesign/cosign
that referenced
this pull request
Sep 25, 2023
We need cred helpers and other info set in the remote opts to resolve the upstream attesations, otherwise this will fail in automated environments. Signed-off-by: Billy Lynch <billy@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need cred helpers and other info set in the remote opts to resolve the upstream attesations, otherwise this will fail in automated environments.
/cc @priyawadhwa @strongjz
Release Note
cosign attestwhere OCI remote configuration wasn't properly set.Documentation
n/a