Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mTLS to TSA for sign-blob command #3200

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Aug 23, 2023

Summary

Clone of #3052 but for the cosign sign-blob command.

Add command-line parameters for key/cert/cacert used for the connection to the TSA server to the sign-blob command.

Fixes #3006.

Release Note

  • New features and improvements, including behavioural changes, UI changes and CLI changes
    ** Additional command-line options for cosign sign-blob command for mTLS connection to the TSA server

Documentation

sigstore/docs#239

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #3200 (085208d) into main (1e9bac4) will decrease coverage by 0.09%.
Report is 2 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3200      +/-   ##
==========================================
- Coverage   30.42%   30.33%   -0.09%     
==========================================
  Files         155      155              
  Lines        9798     9827      +29     
==========================================
  Hits         2981     2981              
- Misses       6369     6398      +29     
  Partials      448      448              
Files Changed Coverage Δ
cmd/cosign/cli/options/signblob.go 0.00% <0.00%> (ø)
cmd/cosign/cli/sign/sign_blob.go 0.00% <0.00%> (ø)
cmd/cosign/cli/signblob.go 0.00% <0.00%> (ø)

Signed-off-by: Dmitry S <dsavints@gmail.com>
Signed-off-by: Dmitry S <dsavints@gmail.com>
@dmitris dmitris marked this pull request as ready for review August 24, 2023 21:35
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@znewman01 znewman01 merged commit 126474c into sigstore:main Aug 25, 2023
28 checks passed
@github-actions github-actions bot added this to the v2.2.0 milestone Aug 25, 2023
@dmitris dmitris deleted the sign-blob-tls branch August 25, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for mTLS connection to the TSA (timestamp server)
3 participants