Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to uploading DSSE types to rekor instead of intoto #3113

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

bobcallaway
Copy link
Member

Summary

This switches cosign from uploading intoto Rekor types when dealing with intoto attestations to using dsse Rekor types. This will result in attestations no longer being stored by Rekor, and enforces a more correct behavior in that attestations should be stored along side the artifact in a registry and/or in a bundle file.

Release Note

  • cosign now uploads entries to Rekor instances for intoto attestations using the dsse Rekor type. This means that Rekor will no longer return the attestation content as part of an entry response. The entry response includes a digest over both the full DSSE envelope as well as the payload content for verifiers to compare against local copies of the DSSE envelope.

Signed-off-by: Bob Callaway <bcallaway@google.com>
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #3113 (0f4ec60) into main (10a5237) will decrease coverage by 0.02%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##             main    #3113      +/-   ##
==========================================
- Coverage   30.43%   30.42%   -0.02%     
==========================================
  Files         155      155              
  Lines        9794     9798       +4     
==========================================
  Hits         2981     2981              
- Misses       6365     6369       +4     
  Partials      448      448              
Files Changed Coverage Δ
cmd/cosign/cli/attest/attest.go 0.00% <0.00%> (ø)
cmd/cosign/cli/attest/attest_blob.go 29.11% <0.00%> (ø)
pkg/cosign/tlog.go 36.70% <33.33%> (-0.43%) ⬇️

@bobcallaway
Copy link
Member Author

Rekor instance launched by scaffolding is quite old, sigstore/scaffolding#701 needs to merge and a new release cut before that will pass.

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only question is if you think we should do a minor version bump of cosign instead of a patch. This isn’t a breaking change, unless clients are currently relying on this storage.

Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway merged commit b9831ca into sigstore:main Aug 15, 2023
28 checks passed
@github-actions github-actions bot added this to the v2.2.0 milestone Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants