Fix unsafe evaluation of inputs.use-sudo #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code was (presumably mistakenly) running inputs.use-sudo as a command, which worked assuming it was true or false (as they ignore their arguments), but this results in the action executing the value of inputs.use-sudo as a command. Signed-off-by: Hal Blackburn <hwtb2@cam.ac.uk>
haydentherapper
approved these changes
May 16, 2023
bobcallaway
approved these changes
May 16, 2023
ianlewis
pushed a commit
to slsa-framework/slsa-github-generator
that referenced
this pull request
Jun 12, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | actions/checkout | action | digest | `8e5e7e5` -> `96f5310` | | [actions/checkout](https://togithub.com/actions/checkout) | action | patch | `v3.5.2` -> `v3.5.3` | | [actions/setup-go](https://togithub.com/actions/setup-go) | action | patch | `v4.0.0` -> `v4.0.1` | | actions/setup-java | action | digest | `5ffc13f` -> `87c1c70` | | [github/codeql-action](https://togithub.com/github/codeql-action) | action | patch | `v2.3.3` -> `v2.3.6` | | [sigstore/cosign-installer](https://togithub.com/sigstore/cosign-installer) | action | patch | `v3.0.3` -> `v3.0.5` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>actions/checkout</summary> ### [`v3.5.3`](https://togithub.com/actions/checkout/blob/HEAD/CHANGELOG.md#v353) [Compare Source](https://togithub.com/actions/checkout/compare/v3.5.2...v3.5.3) - [Fix: Checkout fail in self-hosted runners when faulty submodule are checked-in](https://togithub.com/actions/checkout/pull/1196) - [Fix typos found by codespell](https://togithub.com/actions/checkout/pull/1287) - [Add support for sparse checkouts](https://togithub.com/actions/checkout/pull/1369) </details> <details> <summary>actions/setup-go</summary> ### [`v4.0.1`](https://togithub.com/actions/setup-go/releases/tag/v4.0.1) [Compare Source](https://togithub.com/actions/setup-go/compare/v4.0.0...v4.0.1) ##### What's Changed - Update documentation for `v4` by [@​dsame](https://togithub.com/dsame) in [actions/setup-go#354 - Fix glob bug in the package.json scripts section by [@​IvanZosimov](https://togithub.com/IvanZosimov) in [actions/setup-go#359 - Bump `xml2js` dependency by [@​dmitry-shibanov](https://togithub.com/dmitry-shibanov) in [actions/setup-go#370 - Bump `@actions/cache` dependency to v3.2.1 by [@​nikolai-laevskii](https://togithub.com/nikolai-laevskii) in [actions/setup-go#374 ##### New Contributors - [@​nikolai-laevskii](https://togithub.com/nikolai-laevskii) made their first contribution in [actions/setup-go#374 **Full Changelog**: actions/setup-go@v4...v4.0.1 </details> <details> <summary>github/codeql-action</summary> ### [`v2.3.6`](https://togithub.com/github/codeql-action/compare/v2.3.5...v2.3.6) [Compare Source](https://togithub.com/github/codeql-action/compare/v2.3.5...v2.3.6) ### [`v2.3.5`](https://togithub.com/github/codeql-action/compare/v2.3.4...v2.3.5) [Compare Source](https://togithub.com/github/codeql-action/compare/v2.3.4...v2.3.5) ### [`v2.3.4`](https://togithub.com/github/codeql-action/compare/v2.3.3...v2.3.4) [Compare Source](https://togithub.com/github/codeql-action/compare/v2.3.3...v2.3.4) </details> <details> <summary>sigstore/cosign-installer</summary> ### [`v3.0.5`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.0.5) [Compare Source](https://togithub.com/sigstore/cosign-installer/compare/v3.0.4...v3.0.5) #### What's Changed - download cosign releases from GitHub rather than GCS by [@​bobcallaway](https://togithub.com/bobcallaway) in [sigstore/cosign-installer#126 **Full Changelog**: sigstore/cosign-installer@v3.0.4...v3.0.5 ### [`v3.0.4`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.0.4) [Compare Source](https://togithub.com/sigstore/cosign-installer/compare/v3.0.3...v3.0.4) - Include fix for [sigstore/cosign-installer#124 - changes download URL for `cosign` binary to github.com instead of GCS </details> --- ### Configuration 📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/slsa-framework/slsa-github-generator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40OC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMTEwLjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Signed-off-by: Renovate Bot <bot@renovateapp.com>
Racer159
pushed a commit
to defenseunicorns/zarf
that referenced
this pull request
Dec 19, 2023
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [sigstore/cosign-installer](https://togithub.com/sigstore/cosign-installer) | action | major | `v2.8.1` -> `v3.3.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>sigstore/cosign-installer (sigstore/cosign-installer)</summary> ### [`v3.3.0`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.3.0) [Compare Source](https://togithub.com/sigstore/cosign-installer/compare/v3.2.0...v3.3.0) #### What's Changed - Bump actions/setup-go from 4.1.0 to 5.0.0 by [@​dependabot](https://togithub.com/dependabot) in [sigstore/cosign-installer#152 - update action to use latest cosign v2.2.2 by [@​cpanato](https://togithub.com/cpanato) in [sigstore/cosign-installer#153 **Full Changelog**: sigstore/cosign-installer@v3.2.0...v3.3.0 ### [`v3.2.0`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.2.0) [Compare Source](https://togithub.com/sigstore/cosign-installer/compare/v3.1.2...v3.2.0) **Note: This release comes with a fix for CVE-2023-46737 described in this [Github Security Advisory](https://togithub.com/sigstore/cosign/security/advisories/GHSA-vfp6-jrw2-99g9). Please upgrade to this release ASAP** see https://github.com/sigstore/cosign/releases/tag/v2.2.1 #### What's Changed - Support the runner context of gitea act by [@​josedev-union](https://togithub.com/josedev-union) in [sigstore/cosign-installer#147 - bump cosign to v2.2.1 by [@​cpanato](https://togithub.com/cpanato) in [sigstore/cosign-installer#148 - test with latest go version by [@​bobcallaway](https://togithub.com/bobcallaway) in [sigstore/cosign-installer#150 #### New Contributors - [@​josedev-union](https://togithub.com/josedev-union) made their first contribution in [sigstore/cosign-installer#147 **Full Changelog**: sigstore/cosign-installer@v3...v3.2.0 ### [`v3.1.2`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.1.2) [Compare Source](https://togithub.com/sigstore/cosign-installer/compare/v3.1.1...v3.1.2) #### What's Changed - Fix build and push step Readme missing id by [@​hbenali](https://togithub.com/hbenali) in [sigstore/cosign-installer#138 - bump cosign to v2.2.0 by [@​cpanato](https://togithub.com/cpanato) in [sigstore/cosign-installer#142 #### New Contributors - [@​hbenali](https://togithub.com/hbenali) made their first contribution in [sigstore/cosign-installer#138 **Full Changelog**: sigstore/cosign-installer@v3...v3.1.2 ### [`v3.1.1`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.1.1) [Compare Source](https://togithub.com/sigstore/cosign-installer/compare/v3.1.0...v3.1.1) #### What's Changed - default cosign to v2.1.1 by [@​cpanato](https://togithub.com/cpanato) in [sigstore/cosign-installer#137 **Full Changelog**: sigstore/cosign-installer@v3.1.0...v3.1.1 ### [`v3.1.0`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.1.0) [Compare Source](https://togithub.com/sigstore/cosign-installer/compare/v3.0.5...v3.1.0) #### What's Changed - update job to use latest action release by [@​cpanato](https://togithub.com/cpanato) in [sigstore/cosign-installer#130 - Update action example for keyless signing as xarg is not required by [@​jbtrystram](https://togithub.com/jbtrystram) in [sigstore/cosign-installer#132 - update examples by [@​cpanato](https://togithub.com/cpanato) in [sigstore/cosign-installer#133 - bump cosign to default to release v2.1.0 and update docs by [@​cpanato](https://togithub.com/cpanato) in [sigstore/cosign-installer#136 #### New Contributors - [@​jbtrystram](https://togithub.com/jbtrystram) made their first contribution in [sigstore/cosign-installer#132 **Full Changelog**: sigstore/cosign-installer@v3.0.5...v3.1.0 ### [`v3.0.5`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.0.5) [Compare Source](https://togithub.com/sigstore/cosign-installer/compare/v3.0.4...v3.0.5) #### What's Changed - download cosign releases from GitHub rather than GCS by [@​bobcallaway](https://togithub.com/bobcallaway) in [sigstore/cosign-installer#126 **Full Changelog**: sigstore/cosign-installer@v3.0.4...v3.0.5 ### [`v3.0.4`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.0.4) [Compare Source](https://togithub.com/sigstore/cosign-installer/compare/v3.0.3...v3.0.4) - Include fix for [sigstore/cosign-installer#124 - changes download URL for `cosign` binary to github.com instead of GCS ### [`v3.0.3`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.0.3) [Compare Source](https://togithub.com/sigstore/cosign-installer/compare/v3.0.2...v3.0.3) ##### What's Changed - bump to cosign v2.0.2 by [@​bobcallaway](https://togithub.com/bobcallaway) in [sigstore/cosign-installer#119 - changes download URL for `cosign` binary to github.com instead of GCS **Full Changelog**: sigstore/cosign-installer@v3.0.2...v3.0.3 ### [`v3.0.2`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.0.2) [Compare Source](https://togithub.com/sigstore/cosign-installer/compare/v3.0.1...v3.0.2) ##### What's Changed - add --yes to example workflow by [@​sebhoss](https://togithub.com/sebhoss) in [sigstore/cosign-installer#110 - Fix aarch64 action run by [@​ananos](https://togithub.com/ananos) in [sigstore/cosign-installer#113 - Bump actions/checkout from 3.3.0 to 3.4.0 by [@​dependabot](https://togithub.com/dependabot) in [sigstore/cosign-installer#115 - Bump actions/setup-go from 3.5.0 to 4.0.0 by [@​dependabot](https://togithub.com/dependabot) in [sigstore/cosign-installer#114 - Bump actions/checkout from 3.4.0 to 3.5.0 by [@​dependabot](https://togithub.com/dependabot) in [sigstore/cosign-installer#116 - default cosign to v2.0.1 by [@​cpanato](https://togithub.com/cpanato) in [sigstore/cosign-installer#117 - changes download URL for `cosign` binary to github.com instead of GCS ##### New Contributors - [@​sebhoss](https://togithub.com/sebhoss) made their first contribution in [sigstore/cosign-installer#110 - [@​ananos](https://togithub.com/ananos) made their first contribution in [sigstore/cosign-installer#113 **Full Changelog**: sigstore/cosign-installer@v3...v3.0.2 ### [`v3.0.1`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.0.1) [Compare Source](https://togithub.com/sigstore/cosign-installer/compare/v3.0.0...v3.0.1) ##### What's Changed - make cosign v2.0.0 default version by [@​developer-guy](https://togithub.com/developer-guy) in [sigstore/cosign-installer#109 - changes download URL for `cosign` binary to github.com instead of GCS **Full Changelog**: sigstore/cosign-installer@v3.0.0...v3.0.1 ### [`v3.0.0`](https://togithub.com/sigstore/cosign-installer/releases/tag/v3.0.0) [Compare Source](https://togithub.com/sigstore/cosign-installer/compare/v2.8.1...v3.0.0) ##### Breaking change Cosign v2 has some breaking changes. Please check those: https://blog.sigstore.dev/cosign-2-0-released/ ##### What's Changed - test: add logs when downloading the public keys by [@​hectorj2f](https://togithub.com/hectorj2f) in [sigstore/cosign-installer#106 - Add support to install v2 and any other cosign release candidate by [@​hectorj2f](https://togithub.com/hectorj2f) in [sigstore/cosign-installer#105 - v2.0.0 release by [@​sabre1041](https://togithub.com/sabre1041) in [sigstore/cosign-installer#108 - changes download URL for `cosign` binary to github.com instead of GCS ##### New Contributors - [@​hectorj2f](https://togithub.com/hectorj2f) made their first contribution in [sigstore/cosign-installer#106 - [@​sabre1041](https://togithub.com/sabre1041) made their first contribution in [sigstore/cosign-installer#108 **Full Changelog**: sigstore/cosign-installer@v2...v3.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/zarf). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3Ljg3LjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have an issue number, but I discussed this just now via email with security@sigstore.dev.
Summary
The previous code was (presumably mistakenly) running inputs.use-sudo as a command, which worked assuming it was true or false (as they ignore their arguments), but this results in the action executing the value of inputs.use-sudo as a command.
Release Note
fix: use bash's conditional syntax when checking value of the
use-sudooption to prevent its value being evaluated as a commandDocumentation
NONE