Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware Argument type #5312

Merged
merged 2 commits into from
May 4, 2022
Merged

Conversation

matt-taylor
Copy link
Contributor

#5311


v6.4.2 introduced breaking changes to the argument types of the middleware client.

@matt-taylor matt-taylor marked this pull request as ready for review May 4, 2022 06:16
@danielvdao
Copy link

danielvdao commented May 4, 2022

I could be wrong, but I think we need to add items["class"] to push_bulk as well, otherwise the middleware only gets invoked in one spot. Here's a code example.

@mperham
Copy link
Collaborator

mperham commented May 4, 2022

Yes, you're missing a similar change in push_bulk.

@mperham mperham merged commit 0cf086f into sidekiq:main May 4, 2022
@mperham
Copy link
Collaborator

mperham commented May 4, 2022

Thank you, especially for the regression test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants