Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cargo-shuttle): use api-provided console url on login if available #1999

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

jonaro00
Copy link
Member

Forward compatible change to move console url logic to the api

Also renamed a constant

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR modifies the login functionality to make the console URL configurable through the API instead of using a hardcoded constant.

  • Removed SHUTTLE_CONSOLE_URL constant from imports in cargo-shuttle/src/args.rs
  • Added hidden console_url field to LoginArgs struct configurable via SHUTTLE_CONSOLE environment variable
  • Change enables forward compatibility for API-driven console URL management

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@jonaro00 jonaro00 merged commit 929f14b into main Mar 11, 2025
20 of 21 checks passed
@jonaro00 jonaro00 deleted the login-to-correct-console branch March 11, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants