Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update async-openai to 0.28.0 #1994

Merged
merged 4 commits into from
Mar 11, 2025
Merged

Update async-openai to 0.28.0 #1994

merged 4 commits into from
Mar 11, 2025

Conversation

skabber
Copy link
Contributor

@skabber skabber commented Mar 6, 2025

Description of change

Update async-openai to 0.28.0
The async-openai upstream version has more Voices available in the text to speech api.
https://platform.openai.com/docs/guides/text-to-speech

How has this been tested? (if applicable)

Locally on my branch.

Verified

This commit was signed with the committer’s verified signature.
allanlewis Allan Lewis
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updates the async-openai dependency from 0.23.0 to 0.28.0 to access expanded text-to-speech voice options in the OpenAI API integration.

  • Significant version jump in resources/openai/Cargo.toml from 0.23.0 to 0.28.0 may require testing for breaking changes
  • Update enables access to new voice options in OpenAI's text-to-speech API
  • Consider adding integration tests specifically for text-to-speech functionality to verify compatibility

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Verified

This commit was signed with the committer’s verified signature.
allanlewis Allan Lewis
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

The removal of the examples directory and its submodule configuration represents a significant structural change to the repository.

  • Removed examples directory and its submodule configuration in .gitmodules that previously linked to ../shuttle-examples.git
  • This change impacts developers who rely on in-repo examples for reference and testing
  • Consider documenting alternative ways to access examples, such as pointing to the separate examples repository

The changes appear unrelated to the async-openai update and may need separate justification or rollback consideration.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

This reverts commit ca62147.
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

Re-added the examples directory as a Git submodule, restoring the reference implementation access for developers.

  • Added back .gitmodules file with path to ../shuttle-examples.git
  • Developers should run git submodule init and git submodule update after pulling these changes
  • Consider adding these submodule initialization steps to the CI pipeline

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

No significant changes found since the last review. The core change remains updating async-openai to version 0.28.0 in resources/openai/Cargo.toml to support expanded text-to-speech voice options.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@oddgrd
Copy link
Contributor

oddgrd commented Mar 10, 2025

Thanks, @skabber! Did you try running our openai example (or something equivalent) and see that there were no breaking changes, by the way?

@skabber
Copy link
Contributor Author

skabber commented Mar 10, 2025

I did run the openai-example locally and it still works.
image

Copy link
Contributor

@oddgrd oddgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@oddgrd oddgrd merged commit 32be9cc into shuttle-hq:main Mar 11, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants