-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update async-openai to 0.28.0 #1994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Updates the async-openai dependency from 0.23.0 to 0.28.0 to access expanded text-to-speech voice options in the OpenAI API integration.
- Significant version jump in
resources/openai/Cargo.toml
from 0.23.0 to 0.28.0 may require testing for breaking changes - Update enables access to new voice options in OpenAI's text-to-speech API
- Consider adding integration tests specifically for text-to-speech functionality to verify compatibility
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
The removal of the examples directory and its submodule configuration represents a significant structural change to the repository.
- Removed
examples
directory and its submodule configuration in.gitmodules
that previously linked to../shuttle-examples.git
- This change impacts developers who rely on in-repo examples for reference and testing
- Consider documenting alternative ways to access examples, such as pointing to the separate examples repository
The changes appear unrelated to the async-openai update and may need separate justification or rollback consideration.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
This reverts commit ca62147.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
Re-added the examples directory as a Git submodule, restoring the reference implementation access for developers.
- Added back
.gitmodules
file with path to../shuttle-examples.git
- Developers should run
git submodule init
andgit submodule update
after pulling these changes - Consider adding these submodule initialization steps to the CI pipeline
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
No significant changes found since the last review. The core change remains updating async-openai to version 0.28.0 in resources/openai/Cargo.toml
to support expanded text-to-speech voice options.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Thanks, @skabber! Did you try running our openai example (or something equivalent) and see that there were no breaking changes, by the way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
Description of change
Update async-openai to 0.28.0
The async-openai upstream version has more Voices available in the text to speech api.
https://platform.openai.com/docs/guides/text-to-speech
How has this been tested? (if applicable)
Locally on my branch.