Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(shared-db): upgrade diesel-async to v0.5.2 #1989

Merged

Conversation

valentinegb
Copy link
Contributor

Description of change

Upgrades shuttle-shared-db's dependency on diesel-async from v0.4.1 to v0.5.2.

How has this been tested? (if applicable)

Clippy gives no warnings, compilation is successful.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR upgrades the diesel-async dependency in shuttle-shared-db from v0.4.1 to v0.5.2, ensuring compatibility with the latest version of this PostgreSQL connection management library.

  • The upgrade affects resources/shared-db/Cargo.toml, changing diesel-async from v0.4.1 to v0.5.2
  • The change maintains the existing feature flags for diesel-async, including the bb8 and deadpool connection pooling options
  • The PR has been verified for compilation success and passes Clippy checks, though more comprehensive testing with actual database connections would be beneficial

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@jonaro00 jonaro00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonaro00 jonaro00 merged commit 2247ed4 into shuttle-hq:main Feb 26, 2025
20 of 21 checks passed
@valentinegb valentinegb deleted the shared-db-diesel-async-upgrade branch February 26, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants