-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cargo-shuttle): redeploy command #1916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Added a new redeploy command to the Shuttle CLI for redeploying previous deployments by their ID.
- Bug: Command handler incorrectly calls
deployment_get
instead ofdeployment_redeploy
incargo-shuttle/src/lib.rs
- Added
redeploy_beta
method toShuttleApiClient
inapi-client/src/lib.rs
for making redeploy API requests - Added
Redeploy
variant withid
parameter toDeploymentCommand
enum incargo-shuttle/src/args.rs
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
Fixed the command handler to correctly call deployment_redeploy
instead of deployment_get
for the redeploy command.
- Fixed incorrect handler function call in
cargo-shuttle/src/lib.rs
by replacingdeployment_get
withdeployment_redeploy
- Added error handling for beta platform check in redeploy command implementation
- Added proper routing for redeploy command in command match statement
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
Based on the latest changes and previous reviews, here is my summary of the updates:
Added deployment status tracking and log handling for the redeploy command implementation.
- Added deployment status tracking and log output functionality in
cargo-shuttle/src/lib.rs
for monitoring redeploy progress - Implemented error handling for failed redeployments with appropriate error messages and status codes
- Added log streaming capability to show deployment progress in real-time
The changes focus on enhancing the user experience by providing better visibility into the redeployment process through status updates and log streaming.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
shuttle deployment redeploy <id>