Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ellipsis props to Card component #3858

Merged
merged 5 commits into from
Dec 24, 2024

Conversation

jellli
Copy link
Contributor

@jellli jellli commented Dec 24, 2024

Why:

I think adding ellipsis props to Card is a reasonable request.

Closes:#3855

What's being changed (if available, include any code snippets, screenshots, or gifs):

image

Check off the following:

  • I have reviewed my changes in staging, available via the View
    deployment
    link in this PR's timeline (this link will be available after
    opening the PR).

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
driesvints Dries Vints
Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: 337bc0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
nextra Patch
nextra-theme-blog Patch
nextra-theme-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2024 2:51pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview Dec 24, 2024 2:51pm

Copy link

vercel bot commented Dec 24, 2024

@jellli is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@jellli
Copy link
Contributor Author

jellli commented Dec 24, 2024

I found prettier is really slow :(

upd
Copy link
Collaborator

@dimaMachina dimaMachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, I pushed my commit to make this behaviour by default IMO

@dimaMachina dimaMachina merged commit bfa61d9 into shuding:main Dec 24, 2024
6 of 9 checks passed
@jellli jellli deleted the jellli/add_ellipsis_prop branch December 24, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants