Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: footnote styles, backlink jump #2104

Merged
merged 13 commits into from Aug 19, 2023
Merged

fix: footnote styles, backlink jump #2104

merged 13 commits into from Aug 19, 2023

Conversation

llllvvuu
Copy link
Contributor

@llllvvuu llllvvuu commented Jul 25, 2023 •
edited

resolves #2097

also removes manual scroll-margin-top hack that applied only to subheading anchors specifically

before:

before.mp4

after:

after.mp4

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023 •
edited

🦋 Changeset detected

Latest commit: e26ee41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
nextra-theme-docs Patch
nextra-theme-blog Patch
nextra Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 25, 2023

@llllvvuu is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 25, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra ❌ Failed (Inspect) Aug 19, 2023 0:15am
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2023 0:15am

@suica
Copy link

suica commented Jul 27, 2023

Same issue here. 👍🏿

@llllvvuu llllvvuu marked this pull request as draft August 17, 2023 00:43
@llllvvuu llllvvuu marked this pull request as ready for review August 17, 2023 01:06
dimaMachina
dimaMachina approved these changes Aug 19, 2023
View reviewed changes
Copy link
Collaborator

@dimaMachina dimaMachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the tip with scroll-padding property, btw ## Footnotes should be appeared only for screen readers see at the bottom (for this reason he has sr-only class) https://github.com/gatsbyjs/gatsby/blob/master/examples/using-remark/src/pages/2016-04-15---hello-world-kitchen-sink/index.md#user-content-fn-1-6a1ee311dd33d198f817867c028b8293

@llllvvuu
Copy link
Contributor Author

## Footnotes should be appeared only for screen readers see at the bottom (for this reason he has sr-only class)

Great catch 🔥

@llllvvuu llllvvuu changed the title fix: apply <h2/> styles to footnote heading, fix backlink jump fix: footnote styles, backlink jump Aug 19, 2023
@dimaMachina dimaMachina merged commit cf5f91e into shuding:main Aug 19, 2023
4 of 8 checks passed
@dimaMachina dimaMachina mentioned this pull request Aug 20, 2023
Closed
tatukoivisto pushed a commit to tatukoivisto/nextra that referenced this pull request Aug 20, 2023
@llllvvuu @dimaMachina
fix: footnote styles, backlink jump (shuding#2104)
778b13f 
Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaMachina dimaMachina dimaMachina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Footnotes <h2 /> is unstyled in docs theme
3 participants
@llllvvuu @suica @dimaMachina