Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support multiple overridden syntax themes #1992

Merged
merged 16 commits into from Aug 19, 2023

Conversation

jay3332
Copy link
Contributor

@jay3332 jay3332 commented Jun 20, 2023

Fixes #1974

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2023

⚠️ No Changeset found

Latest commit: dfdd8bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra ❌ Failed (Inspect) Aug 19, 2023 1:50pm
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2023 1:50pm

@vercel
Copy link

vercel bot commented Jun 20, 2023

@jay3332 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@dimaMachina dimaMachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add an example with 2 themes in examples/docs?

Copy link
Collaborator

@dimaMachina dimaMachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to not add support for multiple themes, since rendering multiple code blocks for each theme is awful.

However, in the future, multiple themes will be supported. You can track the progress in shikiji (newly fork of Shiki) https://github.com/antfu/shikiji#multiple-themes that already supports multiple themes without rendering multiple code blocks.

Also, I will merge your contribution to syntax docs with Custom Grammar and Custom Themes sections

@dimaMachina dimaMachina merged commit d39102f into shuding:main Aug 19, 2023
5 of 8 checks passed
tatukoivisto pushed a commit to tatukoivisto/nextra that referenced this pull request Aug 20, 2023
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rehype Pretty Code Multiple themes not supported
2 participants