New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support multiple overridden syntax themes #1992
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@jay3332 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add an example with 2 themes in examples/docs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to not add support for multiple themes, since rendering multiple code blocks for each theme is awful.
However, in the future, multiple themes will be supported. You can track the progress in shikiji (newly fork of Shiki) https://github.com/antfu/shikiji#multiple-themes that already supports multiple themes without rendering multiple code blocks.
Also, I will merge your contribution to syntax docs with Custom Grammar
and Custom Themes
sections
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com> Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
Fixes #1974