New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: can't build package on windows #1894
Conversation
|
@AkaraChen is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
packages/nextra/tsup.config.ts
Outdated
@@ -14,6 +14,8 @@ const CLIENT_ENTRY = [ | |||
const entries = fg.sync(CLIENT_ENTRY, { absolute: true }) | |||
const entriesSet = new Set(entries) | |||
|
|||
const winPath = (p: string) => p.replace(/\\/g, '/') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use slash
package for this case (he is already installed in nextra)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use
slash
package for this case (he is already installed in nextra)
Edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* fix: can't build package on windows * chore: replace winPath with slash
* fix: can't build package on windows * chore: replace winPath with slash
On windows,
fast-glob
return path use '/' as separator, but esbuild use '\', causing the esbuild pluginadd-mjs
can't identify client import, so thenextra
package build output client script as.mjs
: