New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(callout): Move Callout component to nextra/components #1864
feat(callout): Move Callout component to nextra/components #1864
Conversation
🦋 Changeset detectedLatest commit: 818aa97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@tristandubbeld is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
@@ -111,6 +111,7 @@ | |||
"@mdx-js/mdx": "^2.3.0", | |||
"@mdx-js/react": "^2.3.0", | |||
"@napi-rs/simple-git": "^0.1.8", | |||
"clsx": "^1.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of using clsx
we can use something like TypeToClassName
like we do with emojis, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is totally fine to use clsx
in nextra, because I want to move other components from nextra-theme-docs
to nextra too - Tabs, Steps, FileTree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you need help with those 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! You can work on it, thank you!
.nx-prose .nextra-callout p { | ||
@apply nx-m-0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@B2o5T I can move the |
I think is reasonable to move these docs to Nextra pages since nextra-theme-docs now just reexport them |
Should we add a redirect from |
about redirect - nice catch, you can add it and about changeset - |
f0e4fca
to
39a4477
Compare
@tristandubbeld Sorry I was OOO last week, I'll release it today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To enable usage of the
Callout
component in docs, blog and custom themes, we extract it to thenextra
package components folder and export it from there.In this PR
Callout
component fromnextra-theme-docs
tonextra/components
.clsx
package usage innextra
components.