Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issues for text and navbar in light mode #1858

Merged
merged 10 commits into from May 22, 2023

Conversation

filiphuhta
Copy link
Contributor

@filiphuhta filiphuhta commented May 14, 2023

I need to say first that I really liked the blog template! 🤩

When I tested my website with Google PageSpeed which is based on the blog template, I found some issues according to Accessibility for some elements.

Why:
The current blog theme navbar and text for post content have insufficient contrast between the background and text color for the <p>, <time>, and <span> elements in light mode.

What:

  • I updated the navbar in nav.tsx so it passes the WCAG 2 (AA) standard in light mode.
  • I updated the text content and date of the posts in posts-layout.tsx so it passes the WCAG 2 (AA) standard in light mode

Read more about WCAG 2 AA standard.

@changeset-bot
Copy link

changeset-bot bot commented May 14, 2023

🦋 Changeset detected

Latest commit: fa82216

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
nextra-theme-blog Patch
nextra Patch
nextra-theme-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextra-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 2:26pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nextra ⬜️ Ignored (Inspect) Visit Preview May 22, 2023 2:26pm

@vercel
Copy link

vercel bot commented May 14, 2023

@filiphuhta is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

nguyenvukhang and others added 3 commits May 15, 2023 17:06
Update table.mdx

Possibly outdated docs? currently working with 2.5.2 and this seems to be the structure
…huding#1862)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@filiphuhta filiphuhta changed the title fixed accessability issue in light mode for nav bar fixed accessibility issues in light mode for text and nav bar May 16, 2023
@filiphuhta filiphuhta changed the title fixed accessibility issues in light mode for text and nav bar Accessibility issues in light mode for text and nav bar May 16, 2023
@filiphuhta filiphuhta changed the title Accessibility issues in light mode for text and nav bar Accessibility issues for text and navbar in light mode May 16, 2023
Copy link
Collaborator

@dimaMachina dimaMachina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@dimaMachina dimaMachina merged commit 9d9bc23 into shuding:main May 22, 2023
5 of 7 checks passed
filiphuhta added a commit to filiphuhta/nextra that referenced this pull request May 24, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Khang <brew4k@gmail.com>
Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
filiphuhta added a commit to filiphuhta/nextra that referenced this pull request May 24, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Khang <brew4k@gmail.com>
Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
filiphuhta added a commit to filiphuhta/nextra that referenced this pull request May 25, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Khang <brew4k@gmail.com>
Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
filiphuhta added a commit to filiphuhta/nextra that referenced this pull request May 25, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Khang <brew4k@gmail.com>
Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
filiphuhta added a commit to filiphuhta/nextra that referenced this pull request May 25, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Khang <brew4k@gmail.com>
Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
filiphuhta added a commit to filiphuhta/nextra that referenced this pull request May 25, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Khang <brew4k@gmail.com>
Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
filiphuhta added a commit to filiphuhta/nextra that referenced this pull request May 25, 2023
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Khang <brew4k@gmail.com>
Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants