-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Rails to 7.1.1 #1324
Upgrade Rails to 7.1.1 #1324
Conversation
kartiki975
commented
Jan 26, 2024
•
edited
edited
- Upgraded rails 7.1.1 for an internal Shopify ticket
- Removed mini_racer gem; see the comments below for more details
c466bc4
to
6dcb970
Compare
@casperisfine Post rails upgrade, mini_racer is breaking wherever Ruby version is less than 3.2 in the Github Actions. Looking at https://github.com/rubyjs/mini_racer?tab=readme-ov-file#supported-ruby-versions--troubleshooting, it seems like there is no workaround where the Ruby version is less than 3.2:
Note, I have tried this with the existing and now, the latest version of mini_racer here: ba2c64a. At this point, there two actions I can take:
Thoughts? |
We can remove mini_racer and if nodejs is around, |
d0004c8
to
4f72bee
Compare
This reverts commit af3c043.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me but I'd aim for at least one more approval on it!
Thanks for taking care of the upgrade, LGTM. However next time please try to keep a clean git history, |
Worth setting the repo to force squash merges? Works wonders at my shop. |
It's one solution, but has its own downsides as some PR do legitimately contain more than one commit, e.g. a refactoring followed by a feature, etc. Anyway, this was a general advice for contribution to all projects, not specific to |