Remove obsolete Sorbet/OneAncestorPerLine cop
#206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambostock
force-pushed
the
deprecate-one-ancestor-per-line
branch
from
d8fb2c6
to
1314ae3
Compare
Merged
sambostock
force-pushed
the
deprecate-one-ancestor-per-line
branch
from
1314ae3
to
e3ace9d
Compare
Since `require_ancestor` no longer accepts arguments, this cop is obsolete.
sambostock
force-pushed
the
deprecate-one-ancestor-per-line
branch
from
e3ace9d
to
c517b7f
Compare
Morriar
approved these changes
Apr 5, 2024
st0012
added a commit
that referenced
this pull request
Apr 29, 2024
This cop has been removed in #206, so we should remove it from the rubocop config as well. Otherwise, downstream users will see this error: ``` Error: The `Sorbet/OneAncestorPerLine` cop has been removed since `require_ancestor` now takes a block instead of arguments. (obsolete configuration found in vendor/bundle/ruby/3.3.0/gems/rubocop-sorbet-0.8.2/config/rbi.yml, please update it) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
require_ancestorno longer accepts arguments, this cop is obsolete.