Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ForbidUnusedMatchResultRule needs fixing after PHPStan change #186

Closed
ondrejmirtes opened this issue Dec 11, 2023 · 0 comments · Fixed by #189
Closed

ForbidUnusedMatchResultRule needs fixing after PHPStan change #186

ondrejmirtes opened this issue Dec 11, 2023 · 0 comments · Fixed by #189

Comments

@ondrejmirtes
Copy link

After merging phpstan/phpstan-src#2778 your rule ForbidUnusedMatchResultRule fails with false positives.

I think it can be fixed by using $scope->getKeepVoidType() instead of $scope->getType().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

forbidUnusedMatchResult: fix void issue in PHPStan >= 1.10.49 shipmonk-rnd/phpstan-rules
1 participant
@ondrejmirtes