forbidReturnValueInYieldingMethod #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsavmic
reviewed
Sep 7, 2023
| @@ -580,6 +583,28 @@ enum MyEnum { | |||
| } | |||
| ``` | |||
|
|
|||
| ### forbidReturnValueInYieldingMethod | |||
| - Disallows returning values in yielding methods unless marked to return Generator as the value is accessible only via [Generator::getReturn](https://www.php.net/manual/en/generator.getreturn.php) | |||
| - To prevent misuse, this rule can be configured to even stricter mode where it reports such returns regardless of return type declared | |||
There was a problem hiding this comment.
Looking at this for second time, I find this as such a niche use-case that I'd make it strict by default with option to disable it.
With PHPStan error identifiers, it's sounds like a good tradeoff (to whitelist proper usages)
| } | ||
|
|
||
| if ($methodReflection !== null) { | ||
| return ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType(); |
There was a problem hiding this comment.
I don't see test cases for generics and I'm not sure if this method is going to return once you use generics in the method definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.