Improve forbidIdenticalClassComparison example #104
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Brick classes here was a good inspiration, thanks for that!
However:
DateTimeInterface
from here... the array is merged with the default configuration fromrules.neon
anyway so this wayDateTimeInterface
actually gets intoForbidIdenticalClassComparisonRule
twice, I checked.Brick\Money
doesn't exist, it'sBrick\Money\Money
and I think it's better to use the interface instead anyway to also detectBrick\Money\RationalMoney
.BigInteger
,BigDecimal
andBigRational
all extendBigNumber
anyway so they're redundant.ramsey/uuid
is a very commonly used library and I almost forgot to addUuidInterface
into my config.